[NetInfo] Add MaxBandwidthChanged notification and implement on Android

net/android/network_change_notifier_delegate_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/android/network_change_notifier_delegate_android.h"
 
 #include "base/logging.h"
 #include "jni/NetworkChangeNotifier_jni.h"
 #include "net/android/network_change_notifier_android.h"
 
@@ skipping 78 matching lines @@
 }
 
 void NetworkChangeNotifierDelegateAndroid::NotifyConnectionTypeChanged(
     JNIEnv* env,
     jobject obj,
     jint new_connection_type) {
   DCHECK(thread_checker_.CalledOnValidThread());
   const ConnectionType actual_connection_type = ConvertConnectionType(
       new_connection_type);
   SetCurrentConnectionType(actual_connection_type);
-  SetCurrentMaxBandwidth(Java_NetworkChangeNotifier_getCurrentMaxBandwidth(
-      env, java_network_change_notifier_.obj()));
   observers_->Notify(&Observer::OnConnectionTypeChanged);
 }
 
 jint NetworkChangeNotifierDelegateAndroid::GetConnectionType(JNIEnv*,
                                                              jobject) const {
   DCHECK(thread_checker_.CalledOnValidThread());
   return GetCurrentConnectionType();
 }
 
+void NetworkChangeNotifierDelegateAndroid::NotifyMaxBandwidthChanged(
+    JNIEnv* env,
+    jobject obj,
+    jdouble new_max_bandwidth) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(new_max_bandwidth != connection_max_bandwidth_);

[pauljensen, 2014/12/11 16:13:57]

I think this is missing the lock; shouldn't it call GetCurrentMaxBandwidth()?

[jkarlin, 2014/12/15 19:43:55]

Done. Thanks!

+  SetCurrentMaxBandwidth(new_max_bandwidth);
+  observers_->Notify(&Observer::OnMaxBandwidthChanged, new_max_bandwidth);
+}
+
 void NetworkChangeNotifierDelegateAndroid::AddObserver(
     Observer* observer) {
   observers_->AddObserver(observer);
 }
 
 void NetworkChangeNotifierDelegateAndroid::RemoveObserver(
     Observer* observer) {
   observers_->RemoveObserver(observer);
 }
 
@@ skipping 18 matching lines @@
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_NetworkChangeNotifier_forceConnectivityState(env, true);
 }
 
 void NetworkChangeNotifierDelegateAndroid::SetOffline() {
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_NetworkChangeNotifier_forceConnectivityState(env, false);
 }
 
 }  // namespace net