[NetInfo] Add MaxBandwidthChanged notification and implement on Android

net/android/network_change_notifier_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 ////////////////////////////////////////////////////////////////////////////////
 // Threading considerations:
 //
 // This class is designed to meet various threading guarantees starting from the
 // ones imposed by NetworkChangeNotifier:
 // - The notifier can be constructed on any thread.
@@ skipping 79 matching lines @@
 
   virtual void CleanUp() override {
     dns_config_service_.reset();
   }
 
   static void NotifyNetworkChangeNotifierObservers() {
     NetworkChangeNotifier::NotifyObserversOfIPAddressChange();
     NetworkChangeNotifier::NotifyObserversOfConnectionTypeChange();
   }
 
+  static void NotifyMaxBandwidthChangedObservers(double max_bandwidth_mbps) {

[pauljensen, 2014/12/11 16:13:56]

Can we remove this function?  I don't see a reason for it.  Can we just move the
contents into the one caller?  I think NotifyNetworkChangeNotifierObservers()
only exists because it's one caller isn't static so it cannot be merged into it.

[jkarlin, 2014/12/15 19:43:55]

Done.

+    NetworkChangeNotifier::NotifyObserversOfMaxBandwidthChange(
+        max_bandwidth_mbps);
+  }
+
  private:
   scoped_ptr<DnsConfigService> dns_config_service_;
   // Used to detect tunnel state changes.
   internal::AddressTrackerLinux address_tracker_;
 
   DISALLOW_COPY_AND_ASSIGN(DnsConfigServiceThread);
 };
 
 NetworkChangeNotifierAndroid::~NetworkChangeNotifierAndroid() {
   delegate_->RemoveObserver(this);
 }
 
 NetworkChangeNotifier::ConnectionType
 NetworkChangeNotifierAndroid::GetCurrentConnectionType() const {
   return delegate_->GetCurrentConnectionType();
 }
 
 double NetworkChangeNotifierAndroid::GetCurrentMaxBandwidth() const {
   return delegate_->GetCurrentMaxBandwidth();
 }
 
 void NetworkChangeNotifierAndroid::OnConnectionTypeChanged() {
   DnsConfigServiceThread::NotifyNetworkChangeNotifierObservers();
 }
 
+void NetworkChangeNotifierAndroid::OnMaxBandwidthChanged(
+    double max_bandwidth_mbps) {
+  DnsConfigServiceThread::NotifyMaxBandwidthChangedObservers(
+      max_bandwidth_mbps);
+}
+
 // static
 bool NetworkChangeNotifierAndroid::Register(JNIEnv* env) {
   return NetworkChangeNotifierDelegateAndroid::Register(env);
 }
 
 NetworkChangeNotifierAndroid::NetworkChangeNotifierAndroid(
     NetworkChangeNotifierDelegateAndroid* delegate)
     : NetworkChangeNotifier(NetworkChangeCalculatorParamsAndroid()),
       delegate_(delegate),
       dns_config_service_thread_(new DnsConfigServiceThread()) {
@@ skipping 10 matching lines @@
   // so delay IPAddressChanged so they get merged with the following
   // ConnectionTypeChanged signal.
   params.ip_address_offline_delay_ = base::TimeDelta::FromSeconds(1);
   params.ip_address_online_delay_ = base::TimeDelta::FromSeconds(1);
   params.connection_type_offline_delay_ = base::TimeDelta::FromSeconds(0);
   params.connection_type_online_delay_ = base::TimeDelta::FromSeconds(0);
   return params;
 }
 
 }  // namespace net