Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc

Issue 780293002: gpu: fix gpu process crashed on win_blink_rel due to dcheck in CopyTextureCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc b/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
index ffb9370bca76f071a1a3619a96e9a858007bafda..7a46350d984aa23947661c8c2e01b3bbc5d83fc6 100644
--- a/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
+++ b/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
@@ -260,8 +260,9 @@ CopyTextureCHROMIUMResourceManager::CopyTextureCHROMIUMResourceManager()
framebuffer_(0u) {}
CopyTextureCHROMIUMResourceManager::~CopyTextureCHROMIUMResourceManager() {
- DCHECK(!buffer_id_);
- DCHECK(!framebuffer_);
+ // |buffer_id_| and |framebuffer_| can be not-null because when GPU context is
+ // lost, this class can be deleted without releasing resources like
+ // GLES2DecoderImpl.
piman 2014/12/05 20:34:12 nit: is there a way to check that the GL resources
}
void CopyTextureCHROMIUMResourceManager::Initialize(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698