Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 780263003: Move GrPorterDuffXferProcessor to include/gpu/effects. (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Move GrPorterDuffXferProcessor to include/gpu/effects. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8bf2bd335f39afc29d7829ad11aa440945c2d37a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove duplicated line #

Patch Set 3 : Fix gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -80 lines) Patch
M gyp/gpu.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/gpu.gypi View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A + include/gpu/effects/GrPorterDuffXferProcessor.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/gpu/effects/GrPorterDuffXferProcessor.h View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
egdaniel
6 years ago (2014-12-05 16:15:15 UTC) #2
bsalomon
https://codereview.chromium.org/780263003/diff/1/gyp/gpu.gypi File gyp/gpu.gypi (right): https://codereview.chromium.org/780263003/diff/1/gyp/gpu.gypi#newcode45 gyp/gpu.gypi:45: '<(skia_include_path)/gpu/gl/GrGLSLPrettyPrint.h', should this be in include?
6 years ago (2014-12-05 16:30:18 UTC) #3
egdaniel
https://codereview.chromium.org/780263003/diff/1/gyp/gpu.gypi File gyp/gpu.gypi (right): https://codereview.chromium.org/780263003/diff/1/gyp/gpu.gypi#newcode45 gyp/gpu.gypi:45: '<(skia_include_path)/gpu/gl/GrGLSLPrettyPrint.h', On 2014/12/05 16:30:17, bsalomon wrote: > should this ...
6 years ago (2014-12-05 19:33:41 UTC) #4
bsalomon
lgtm
6 years ago (2014-12-05 19:39:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780263003/20001
6 years ago (2014-12-05 19:46:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1354)
6 years ago (2014-12-05 19:49:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780263003/40001
6 years ago (2014-12-05 20:06:08 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-05 20:14:31 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8bf2bd335f39afc29d7829ad11aa440945c2d37a

Powered by Google App Engine
This is Rietveld 408576698