Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: ipc/mojo/ipc_message_pipe_reader.cc

Issue 780223002: ChannelProxy: Send() from UI thread when ChannelMojo is used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ipc/mojo/ipc_channel_mojo.cc ('K') | « ipc/mojo/ipc_message_pipe_reader.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/mojo/ipc_message_pipe_reader.cc
diff --git a/ipc/mojo/ipc_message_pipe_reader.cc b/ipc/mojo/ipc_message_pipe_reader.cc
index 36871e76caed8f7c6f04f0a3c4b24c417ea3ae50..fc9775f5581157c76e43fd174eccac31e3fd4f70 100644
--- a/ipc/mojo/ipc_message_pipe_reader.cc
+++ b/ipc/mojo/ipc_message_pipe_reader.cc
@@ -38,7 +38,7 @@ void MessagePipeReader::CloseWithError(MojoResult error) {
Close();
}
-bool MessagePipeReader::Send(scoped_ptr<Message> message) {
+MojoResult MessagePipeReader::Send(scoped_ptr<Message> message) {
DCHECK(IsValid());
message->TraceMessageBegin();
@@ -56,13 +56,9 @@ bool MessagePipeReader::Send(scoped_ptr<Message> message) {
MOJO_WRITE_MESSAGE_FLAG_NONE);
}
- if (result != MOJO_RESULT_OK) {
+ if (result != MOJO_RESULT_OK)
std::for_each(handles.begin(), handles.end(), &MojoClose);
- CloseWithError(result);
- return false;
- }
-
- return true;
+ return result;
}
// static
« ipc/mojo/ipc_channel_mojo.cc ('K') | « ipc/mojo/ipc_message_pipe_reader.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698