Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 780213002: Put code in //services/js in namespace js (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
Reviewers:
hansmuller
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Put code in //services/js in namespace js Also fixes up some include guards. R=hansmuller@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e07f5dc77621715bef1259197530eea986be2c39

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -69 lines) Patch
M services/js/content_handler_main.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M services/js/echo_apptest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M services/js/js_app.h View 4 chunks +7 lines, -9 lines 0 comments Download
M services/js/js_app.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M services/js/js_app_bridge_module.h View 2 chunks +3 lines, -5 lines 0 comments Download
M services/js/js_app_bridge_module.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/js/js_app_message_loop_observers.h View 3 chunks +1 line, -3 lines 0 comments Download
M services/js/js_app_message_loop_observers.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M services/js/js_app_runner_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M services/js/js_app_runner_delegate.cc View 3 chunks +5 lines, -5 lines 1 comment Download
M services/js/js_app_shell.h View 2 chunks +3 lines, -5 lines 0 comments Download
M services/js/js_app_shell.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M services/js/pingpong_apptest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/js/test/js_application_test_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/js/test/js_application_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/js/test/pingpong_service.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
6 years ago (2014-12-05 02:27:13 UTC) #1
hansmuller
On 2014/12/05 02:27:13, jamesr wrote: LTGM
6 years ago (2014-12-05 23:53:42 UTC) #2
hansmuller
LGTM https://codereview.chromium.org/780213002/diff/1/services/js/js_app_runner_delegate.cc File services/js/js_app_runner_delegate.cc (right): https://codereview.chromium.org/780213002/diff/1/services/js/js_app_runner_delegate.cc#newcode35 services/js/js_app_runner_delegate.cc:35: mojo::js::Threading::GetModule); NICE.
6 years ago (2014-12-05 23:54:03 UTC) #3
jamesr
6 years ago (2014-12-08 20:02:33 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e07f5dc77621715bef1259197530eea986be2c39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698