runtime/vm/flags.cc - Issue 780173002: Improve debugger in MIPS simulator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flags.cc

Issue 780173002: Improve debugger in MIPS simulator. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flags.cc

===================================================================

--- runtime/vm/flags.cc (revision 42124)

+++ runtime/vm/flags.cc (working copy)

@@ -208,9 +208,16 @@

}

case Flag::kInteger: {

char* endptr = NULL;

- int val = strtol(argument, &endptr, 10);

- if (endptr != argument) {

+ const intptr_t len = strlen(argument);

+ int base = 10;

+ if ((len > 2) && (argument[0] == '0') && (argument[1] == 'x')) {

+ base = 16;

+ }

+ int val = strtol(argument, &endptr, base);

+ if (endptr == argument + len) {

*flag->int_ptr_ = val;

+ } else {

+ return false;

}

break;

}

« no previous file with comments | « no previous file | runtime/vm/simulator_mips.h » ('j') | runtime/vm/simulator_mips.cc » ('J')