Issue 780083003: Merge StyleElement into HTMLStyleElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 780083003: Merge StyleElement into HTMLStyleElement. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Merge StyleElement into HTMLStyleElement. StyleElement existed because Blink supported <link> and XSL sheets, Sky only supports <style> so we can merge them together. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4aa6ad5946fa7422b0ade36f918781677a01887b

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -255 lines)			Patch
M	sky/engine/core/core.gni	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/engine/core/dom/StyleElement.h	View		1 chunk	+0 lines, -67 lines	0 comments	Download
D	sky/engine/core/dom/StyleElement.cpp	View		1 chunk	+0 lines, -167 lines	0 comments	Download
M	sky/engine/core/html/HTMLStyleElement.h	View		3 chunks	+24 lines, -8 lines	0 comments	Download
M	sky/engine/core/html/HTMLStyleElement.cpp	View	1	5 chunks	+99 lines, -11 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

6 years ago (2014-12-04 21:33:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4aa6ad5946fa7422b0ade36f918781677a01887b (presubmit successful).