Issue 78003002: Removed unused --preallocate-message-memory flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78003002: Removed unused --preallocate-message-memory flag. (Closed)

Created:
7 years, 1 month ago by Sven Panne

Modified:
7 years, 1 month ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Removed unused --preallocate-message-memory flag. It results in a lot of dead code, and Isolate::PrintStack itself crashes most of the time when something went wrong earlier. Furthermore, we have plans do get better information into the minidump, anyway. R=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17918

Patch Set 1 #

Patch Set 2 : Removed more dead code #

Patch Set 3 : Nuked more dead code #

Patch Set 4 : Removed useless test. #

Patch Set 5 : Rebased. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -457 lines)			Patch
M	src/allocation.h	View	1 2	1 chunk	+0 lines, -28 lines	0 comments	Download
M	src/allocation.cc	View	1	1 chunk	+0 lines, -20 lines	0 comments	Download
D	src/allocation-inl.h	View	1 2	1 chunk	+0 lines, -49 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/frames.cc	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/isolate.h	View	1 2	6 chunks	+1 line, -14 lines	0 comments	Download
M	src/isolate.cc	View	1 2	8 chunks	+2 lines, -218 lines	0 comments	Download
M	src/scopeinfo.cc	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/scopes.cc	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/string-stream.cc	View	1 2	2 chunks	+1 line, -4 lines	0 comments	Download
M	test/mjsunit/regexp-multiline-stack-trace.js	View	1 2 3	1 chunk	+0 lines, -116 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

The test was a 1:1 copy from another one, removed. PTAL...

7 years, 1 month ago (2013-11-20 12:34:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r17918.

Expand Messages | Collapse Messages