Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 780013002: nanobench: upload peak memory usage as its own trace. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

nanobench: upload peak memory usage as its own trace. We'll end up with a result like this: "memory_usage" : { "meta" : { "max_rss_mb" : 57 } } BUG=skia: Committed: https://skia.googlesource.com/skia/+/e109145bf31d63963b3f78c6af6e404d5464a55b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M bench/nanobench.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
This'll work when the previous CL lands.
6 years ago (2014-12-04 16:46:11 UTC) #2
jcgregorio
lgtm
6 years ago (2014-12-04 17:56:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780013002/1
6 years ago (2014-12-04 18:06:26 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-04 18:47:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e109145bf31d63963b3f78c6af6e404d5464a55b

Powered by Google App Engine
This is Rietveld 408576698