Source/core/svg/SVGFECompositeElement.cpp - Issue 779963002: Add the 'lighter' composite operation to feComposite.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGFECompositeElement.cpp

Issue 779963002: Add the 'lighter' composite operation to feComposite. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/filters/feComposite-operator-lighter-expected.html ('k') | Source/platform/graphics/filters/FEComposite.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/svg/SVGFECompositeElement.cpp

diff --git a/Source/core/svg/SVGFECompositeElement.cpp b/Source/core/svg/SVGFECompositeElement.cpp

index 6b8a569c53a717adbd706536b9f02e9945277d0a..4eae0695f438d36ee202dd3ad9feb9735cd4ec23 100644

--- a/Source/core/svg/SVGFECompositeElement.cpp

+++ b/Source/core/svg/SVGFECompositeElement.cpp

@@ -38,10 +38,16 @@ template<> const SVGEnumerationStringEntries& getStaticStringEntries<CompositeOp

entries.append(std::make_pair(FECOMPOSITE_OPERATOR_ATOP, "atop"));

entries.append(std::make_pair(FECOMPOSITE_OPERATOR_XOR, "xor"));

entries.append(std::make_pair(FECOMPOSITE_OPERATOR_ARITHMETIC, "arithmetic"));

+ entries.append(std::make_pair(FECOMPOSITE_OPERATOR_LIGHTER, "lighter"));

}

return entries;

}

+template<> unsigned short getMaxExposedEnumValue<CompositeOperationType>()

+ return FECOMPOSITE_OPERATOR_ARITHMETIC;

inline SVGFECompositeElement::SVGFECompositeElement(Document& document)

: SVGFilterPrimitiveStandardAttributes(SVGNames::feCompositeTag, document)

, m_k1(SVGAnimatedNumber::create(this, SVGNames::k1Attr, SVGNumber::create()))