Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 779923002: Make JSTests ready for Android measurements. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
Reviewers:
ulan
CC:
v8-dev, Dmitry Lomov (no reviews), arv (Not doing code reviews), adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Make JSTests ready for Android measurements. This adds a common perf configuration for JSTests including Classes, Collections, Iterators and Strings. This allows the android test runner to handle subdirectories correctly and to share the base.js resource in the parent directory. The new json config has added resources configs for the Android runner. The perf runner's relative paths on the device are fixed as well. Resources are only pushed on the configuration node where they are specified. They are pushed to a dir on the device that follows the same directory structure as on the host. The binary is executed in the benchmark folder on the device like on the host to allow relative path file loading. BUG=chromium:374740 LOG=n TEST=python -m unittest run_perf_test TBR=ulan@chromium.org NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -9 lines) Patch
A test/js-perf-test/JSTests.json View 1 chunk +69 lines, -0 lines 0 comments Download
M tools/run_perf.py View 3 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
PTAL
6 years ago (2014-12-04 10:26:28 UTC) #2
ulan
lgtm
6 years ago (2014-12-04 10:31:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779923002/1
6 years ago (2014-12-04 10:37:29 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-04 10:37:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698