Remove src/trusted/plugin

Remove src/trusted/plugin

This directory now lives in the chromium repository.

BUG= none
TEST= trybots

R=noelallen@chromium.org,bradnelson@google.com,ncbray@google.com,polina@google.com

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6590

[bradn, 2011-08-30 17:21:05]

Lgtm

Drat I'd thought I'd done this
On Aug 30, 2011 10:06 AM, <mcgrathr@chromium.org> wrote:
> Reviewers: noelallen1, bradn, Nick Bray, polina,
>
> Description:
> Remove src/trusted/plugin
>
> This directory now lives in the chromium repository.
>
> BUG= none
> TEST= trybots
>
> R=noelallen@chromium.org,bradnelson@google.com,ncbray@google.com,
polina@google.com
>
>
> Please review this at http://codereview.chromium.org/7799028/
>
> SVN Base: svn://svn.chromium.org/native_client/trunk/src/native_client
>
> Affected files:
> D src/trusted/plugin/arch_arm/sandbox_isa.cc
> D src/trusted/plugin/arch_x86/sandbox_isa.cc
> D src/trusted/plugin/array_ppapi.h
> D src/trusted/plugin/array_ppapi.cc
> D src/trusted/plugin/browser_interface.h
> D src/trusted/plugin/browser_interface.cc
> D src/trusted/plugin/browser_utils.cc
> D src/trusted/plugin/build.scons
> D src/trusted/plugin/delayed_callback.h
> D src/trusted/plugin/desc_based_handle.h
> D src/trusted/plugin/desc_based_handle.cc
> D src/trusted/plugin/dylib_unittest.h
> D src/trusted/plugin/dylib_unittest.cc
> D src/trusted/plugin/file_downloader.h
> D src/trusted/plugin/file_downloader.cc
> D src/trusted/plugin/manifest.h
> D src/trusted/plugin/manifest.cc
> D src/trusted/plugin/method_map.h
> D src/trusted/plugin/method_map.cc
> D src/trusted/plugin/module_ppapi.cc
> D src/trusted/plugin/nacl_entry_points.h
> D src/trusted/plugin/nacl_subprocess.h
> D src/trusted/plugin/nacl_subprocess.cc
> D src/trusted/plugin/nexe_arch.h
> D src/trusted/plugin/nexe_arch.cc
> D src/trusted/plugin/osx_ppapi/Info.plist
> D src/trusted/plugin/osx_ppapi/ppNaClPlugin.r
> D src/trusted/plugin/plugin.cc
> D src/trusted/plugin/plugin.gyp
> D src/trusted/plugin/plugin.gypi
> D src/trusted/plugin/plugin.h
> D src/trusted/plugin/plugin_error.h
> D src/trusted/plugin/plugin_unittest.cc
> D src/trusted/plugin/pnacl_coordinator.h
> D src/trusted/plugin/pnacl_coordinator.cc
> D src/trusted/plugin/pnacl_srpc_lib.h
> D src/trusted/plugin/pnacl_srpc_lib.cc
> D src/trusted/plugin/pnacl_thread_args.h
> D src/trusted/plugin/ppapi.def
> D src/trusted/plugin/scriptable_handle.h
> D src/trusted/plugin/scriptable_handle.cc
> D src/trusted/plugin/service_runtime.h
> D src/trusted/plugin/service_runtime.cc
> D src/trusted/plugin/srpc_client.h
> D src/trusted/plugin/srpc_client.cc
> D src/trusted/plugin/string_encoding.h
> D src/trusted/plugin/string_encoding.cc
> D src/trusted/plugin/string_encoding_test.cc
> D src/trusted/plugin/utility.h
> D src/trusted/plugin/utility.cc
> D src/trusted/plugin/var_utils.h
> D src/trusted/plugin/var_utils.cc
> D src/trusted/plugin/win/nacl_plugin.rc
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[Roland McGrath, 2011-08-30 17:24:28]

I needed a gyp change to fix the build after this.
PTAL

[bradn, 2011-08-30 17:47:17]

Lgtm I'm cell phone only at the moment I didn't make the same mistake with
the tests directory did I?
On Aug 30, 2011 10:24 AM, <mcgrathr@chromium.org> wrote:
> I needed a gyp change to fix the build after this.
> PTAL
>
> http://codereview.chromium.org/7799028/

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[polina, 2011-08-30 18:40:10]

LGTM
Thanks!

[Mark Seaborn, 2011-09-01 01:09:54]

It looks like this has broken Chromium integration.  The Mac compile is failing
with:

i686-apple-darwin10-g++-4.2.1:
../../../../../native_client/src/trusted/plugin/ppapi.def: No such file or
directory

when linking the plugin.  This breaks on the integration bot and on DEPS-update
try jobs.

Mark