Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: ui/gfx/render_text.cc

Issue 779793006: MacViews: Use RenderTextHarfBuzz only for Textfields (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename to CreateInstanceOfSameType Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/render_text_harfbuzz.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index add661d64c9d5edc34449ac3b0cf53bc7d102756..4da9880b33ae81ac6005b1a3d7e3db50a4c11fa9 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -398,7 +398,7 @@ RenderText::~RenderText() {
}
RenderText* RenderText::CreateInstance() {
-#if defined(OS_MACOSX) && !defined(TOOLKIT_VIEWS)
+#if defined(OS_MACOSX)
static const bool use_harfbuzz = CommandLine::ForCurrentProcess()->
HasSwitch(switches::kEnableHarfBuzzRenderText);
#else
@@ -408,6 +408,12 @@ RenderText* RenderText::CreateInstance() {
return use_harfbuzz ? new RenderTextHarfBuzz : CreateNativeInstance();
}
+RenderText* RenderText::CreateInstanceForEditing() {
+ static const bool use_harfbuzz = !CommandLine::ForCurrentProcess()->
+ HasSwitch(switches::kDisableHarfBuzzRenderText);
+ return use_harfbuzz ? new RenderTextHarfBuzz : CreateNativeInstance();
+}
+
void RenderText::SetText(const base::string16& text) {
DCHECK(!composition_range_.IsValid());
if (text_ == text)
@@ -1233,7 +1239,7 @@ base::string16 RenderText::Elide(const base::string16& text,
return ElideEmail(text, available_width);
// Create a RenderText copy with attributes that affect the rendering width.
- scoped_ptr<RenderText> render_text(CreateInstance());
+ scoped_ptr<RenderText> render_text = CreateInstanceOfSameType();
render_text->SetFontList(font_list_);
render_text->SetDirectionalityMode(directionality_mode_);
render_text->SetCursorEnabled(cursor_enabled_);
« no previous file with comments | « ui/gfx/render_text.h ('k') | ui/gfx/render_text_harfbuzz.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698