Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 779793004: MIPS: Change CmpWeakValue to a more MIPS like GetWeakValue. (Closed)

Created:
6 years ago by balazs.kilvady
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

MIPS: Change CmpWeakValue to a more MIPS like GetWeakValue. This approach saves one instruction by eliminating the use of Subu as a pseudo-comparison. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -28 lines) Patch
M src/ic/mips/handler-compiler-mips.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
6 years ago (2014-12-04 15:34:40 UTC) #2
paul.l...
The change LGTM, but please amend the commit message body to add that this approach ...
6 years ago (2014-12-04 15:43:58 UTC) #3
dusmil.imgtec
lgtm.
6 years ago (2014-12-04 15:58:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779793004/1
6 years ago (2014-12-04 16:02:36 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-04 16:29:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698