Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 779723002: WebCrypto: Add parsing for the algorithm parameter AesDerivedKey. (Closed)

Created:
6 years ago by eroman
Modified:
6 years ago
CC:
blink-reviews, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

WebCrypto: Add parsing for the algorithm parameter AesDerivedKey. This by the WebCrypto spec: https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#aes-derivedkey-params It will be used to implement the "Get Key Length" operation, which is invoked by deriveKey(). Testing: LayoutTests will be added in a subsequent patch, as they depend on deriveKey() being completed. BUG=437577 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186730

Patch Set 1 #

Total comments: 2

Patch Set 2 : add override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M Source/modules/crypto/NormalizeAlgorithm.cpp View 2 chunks +18 lines, -0 lines 0 comments Download
M Source/platform/exported/WebCryptoAlgorithm.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M public/platform/WebCryptoAlgorithm.h View 3 chunks +3 lines, -0 lines 0 comments Download
M public/platform/WebCryptoAlgorithmParams.h View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
eroman
6 years ago (2014-12-03 20:54:33 UTC) #2
jww
lgtm
6 years ago (2014-12-04 21:42:40 UTC) #3
eroman
@jochen for OWNERS approval
6 years ago (2014-12-04 22:08:48 UTC) #5
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/779723002/diff/1/public/platform/WebCryptoAlgorithmParams.h File public/platform/WebCryptoAlgorithmParams.h (right): https://codereview.chromium.org/779723002/diff/1/public/platform/WebCryptoAlgorithmParams.h#newcode332 public/platform/WebCryptoAlgorithmParams.h:332: virtual WebCryptoAlgorithmParamsType type() const { return WebCryptoAlgorithmParamsTypeAesDerivedKeyParams; } ...
6 years ago (2014-12-08 12:09:16 UTC) #6
eroman
https://codereview.chromium.org/779723002/diff/1/public/platform/WebCryptoAlgorithmParams.h File public/platform/WebCryptoAlgorithmParams.h (right): https://codereview.chromium.org/779723002/diff/1/public/platform/WebCryptoAlgorithmParams.h#newcode332 public/platform/WebCryptoAlgorithmParams.h:332: virtual WebCryptoAlgorithmParamsType type() const { return WebCryptoAlgorithmParamsTypeAesDerivedKeyParams; } On ...
6 years ago (2014-12-08 18:09:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779723002/20001
6 years ago (2014-12-08 19:36:32 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-08 21:15:21 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186730

Powered by Google App Engine
This is Rietveld 408576698