Issue 779633004: MachMessageServer: scribble over memory allocations in debug mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 779633004: MachMessageServer: scribble over memory allocations in debug mode (Closed)

Created:
6 years ago by Mark Mentovai

Modified:
6 years ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

MachMessageServer: scribble over memory allocations in debug mode. This exposed a bug in the ExcClientVariants test, which was expecting the memory used for new_state to be initialized with zeroes. In reality, no guarantee of initialization is made. MIG “out” parameters are strictly “out” and may contain garbage at function entry. TEST=util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/86588c55262f2be0f1608cda499f03c9c533c65d

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -18 lines)			Patch
	M	util/mach/exc_client_variants_test.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	util/mach/mach_message_server.cc	View	1	2 chunks	+24 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

6 years ago (2014-12-03 23:24:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
86588c55262f2be0f1608cda499f03c9c533c65d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages