Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 779633003: CT Google Storage utils to download/upload artifacts for workers (Closed)

Created:
6 years ago by rmistry
Modified:
6 years ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Visibility:
Public.

Description

CT Google Storage utils to download/upload artifacts for workers. BUG=skia:3163 TBR=jcgreogrio Committed: https://skia.googlesource.com/buildbot/+/eed8058e8bc24d0df656ba5d23a342e8a9ca4921

Patch Set 1 : Initial upload #

Patch Set 2 : Fix unit test #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : goimports #

Total comments: 2

Patch Set 5 : Check for test.short #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -3 lines) Patch
M ct/Makefile View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
A ct/go/util/gs.go View 1 chunk +249 lines, -0 lines 0 comments Download
A ct/go/util/gs_test.go View 1 2 3 4 1 chunk +130 lines, -0 lines 0 comments Download
A ct/go/util/testdata/testupload/10ktest/TIMESTAMP View 1 chunk +1 line, -0 lines 0 comments Download
A ct/go/util/testdata/testupload/10ktest/alexa1-1.py View 1 chunk +35 lines, -0 lines 0 comments Download
A ct/go/util/testdata/testupload/10ktest/alexa2-2.py View 1 chunk +35 lines, -0 lines 0 comments Download
M go/auth/auth.go View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
rmistry
6 years ago (2014-12-03 17:57:41 UTC) #3
jcgregorio
https://codereview.chromium.org/779633003/diff/20001/ct/go/util/constants.go File ct/go/util/constants.go (right): https://codereview.chromium.org/779633003/diff/20001/ct/go/util/constants.go#newcode7 ct/go/util/constants.go:7: CT_USER = "rmistry" Looks like a dup from the ...
6 years ago (2014-12-03 19:22:15 UTC) #5
rmistry
https://codereview.chromium.org/779633003/diff/20001/ct/go/util/constants.go File ct/go/util/constants.go (right): https://codereview.chromium.org/779633003/diff/20001/ct/go/util/constants.go#newcode7 ct/go/util/constants.go:7: CT_USER = "rmistry" On 2014/12/03 19:22:14, jcgregorio wrote: > ...
6 years ago (2014-12-03 19:23:20 UTC) #6
rmistry
Rebased
6 years ago (2014-12-03 19:40:39 UTC) #7
jcgregorio
https://codereview.chromium.org/779633003/diff/60001/ct/go/util/gs_test.go File ct/go/util/gs_test.go (right): https://codereview.chromium.org/779633003/diff/60001/ct/go/util/gs_test.go#newcode15 ct/go/util/gs_test.go:15: // Will need a local valid google_storage_token.data file to ...
6 years ago (2014-12-03 19:52:06 UTC) #8
rmistry
https://codereview.chromium.org/779633003/diff/60001/ct/go/util/gs_test.go File ct/go/util/gs_test.go (right): https://codereview.chromium.org/779633003/diff/60001/ct/go/util/gs_test.go#newcode15 ct/go/util/gs_test.go:15: // Will need a local valid google_storage_token.data file to ...
6 years ago (2014-12-04 12:17:02 UTC) #9
rmistry
TBR'ing this for now. Will address additional comments in a future CL.
6 years ago (2014-12-04 14:57:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779633003/80001
6 years ago (2014-12-04 14:58:05 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-04 14:58:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/buildbot/+/eed8058e8bc24d0df656ba5d23a342e8a9ca...

Powered by Google App Engine
This is Rietveld 408576698