Issue 779633002: Small fix in out_of_process_dynamic_service_runner.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 779633002: Small fix in out_of_process_dynamic_service_runner.cc (Closed)

Created:
6 years ago by qsr

Modified:
6 years ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Small fix in out_of_process_dynamic_service_runner.cc R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b957711adda6ea48755504b5575a19e8639d7443

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	mojo/shell/out_of_process_dynamic_service_runner.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	mojo/shell/out_of_process_dynamic_service_runner.cc	View		1 chunk	+0 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

qsr

https://codereview.chromium.org/779633002/diff/1/mojo/shell/out_of_process_dynamic_service_runner.cc File mojo/shell/out_of_process_dynamic_service_runner.cc (left): https://codereview.chromium.org/779633002/diff/1/mojo/shell/out_of_process_dynamic_service_runner.cc#oldcode37 mojo/shell/out_of_process_dynamic_service_runner.cc:37: DCHECK(!service_handle_.is_valid()); The private field is never used, outside of ...

6 years ago (2014-12-03 14:23:05 UTC) #2

qsr

6 years ago (2014-12-03 16:28:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b957711adda6ea48755504b5575a19e8639d7443 (presubmit successful).

Expand Messages | Collapse Messages