[Chromoting] Create core Application interface for CRD.

remoting/webapp/crd/js/session_connector.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Interface abstracting the SessionConnector functionality.
  */
 
 'use strict';
@@ skipping 86 matching lines @@
  * @param {HTMLElement} clientContainer Container element for the client view.
  * @param {function(remoting.ClientSession):void} onConnected Callback on
  *     success.
  * @param {function(remoting.Error):void} onError Callback on error.
  * @param {function(string, string):boolean} onExtensionMessage The handler for
  *     protocol extension messages. Returns true if a message is recognized;
  *     false otherwise.
  * @return {remoting.SessionConnector}
  */
 remoting.SessionConnectorFactory.prototype.createConnector =
+    // TODO(garykac): Can onExtensionMessage be removed from here? It's only
+    // needed to pass to the plugin that is created.

[Jamie, 2014/12/06 01:58:00]

SessionConnector needs to know about onExtensionMessage so that it can pass it
to the ClientSession. However, it looks like all we do is forward it back to the
ClientSession, which begs the question of why the ClientSession needs a callback
in the first place :s

It doesn't need to be fixed in this CL, but there has to be a simpler design
than this...

[garykac, 2014/12/06 02:15:50]

Acknowledged.

     function(clientContainer, onConnected, onError, onExtensionMessage) {};
 
 /**
  * @type {remoting.SessionConnectorFactory}
  */
 remoting.SessionConnector.factory = null;