[Chromoting] Create core Application interface for CRD.

remoting/webapp/crd/js/session_connector.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Interface abstracting the SessionConnector functionality.
  */
 
 'use strict';
@@ skipping 77 matching lines @@
 remoting.SessionConnector.prototype.getHostId = function() {};
 
 
 /**
  * @interface
  */
 remoting.SessionConnectorFactory = function() {};
 
 /**
  * @param {HTMLElement} clientContainer Container element for the client view.
- * @param {function(remoting.ClientSession):void} onConnected Callback on
- *     success.
- * @param {function(remoting.Error):void} onError Callback on error.
- * @param {function(string, string):boolean} onExtensionMessage The handler for
- *     protocol extension messages. Returns true if a message is recognized;
- *     false otherwise.
+ * @param {remoting.Application} app The main application.
  * @return {remoting.SessionConnector}
  */
 remoting.SessionConnectorFactory.prototype.createConnector =
-    function(clientContainer, onConnected, onError, onExtensionMessage) {};
+    function(clientContainer, app) {};

[Jamie, 2014/12/06 00:09:24]

I preferred the previous implementation where onConnected and onError were
passed explicitly. By passing the Application, you're creating a reference cycle
between the app and the connector, which doesn't feel right. Completion/error
callbacks are also very common elsewhere in the JS code-base, so it's more
consistent to express things that way.

[garykac, 2014/12/06 01:39:33]

Done.

 
 /**
  * @type {remoting.SessionConnectorFactory}
  */
 remoting.SessionConnector.factory = null;