[Chromoting] Create core Application interface for CRD.

remoting/webapp/crd/js/crd_main.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
+ * @constructor
+ * @implements {remoting.Application}
+ */
+remoting.RemoteDesktop = function() {

[Jamie, 2014/12/04 22:56:58]

I'm not a fan of this class name, but I'm not sure what to suggest as an
alternative. Maybe DesktopRemoting (as contrasted with AppRemoting)? Also,
please rename this file, since it should be named after the class it defines.

[garykac, 2014/12/05 19:55:40]

Changed to DesktopRemoting.

+};
+
+/**
  * Entry point ('load' handler) for Chromoting webapp.
  */
-remoting.initChromoting = function() {
+remoting.RemoteDesktop.prototype.init = function() {
   remoting.initGlobalObjects();
   remoting.initIdentity();
   remoting.initIdentityEmail(remoting.onEmailAvailable);
 
   remoting.initEventHandlers();
 
   if (base.isAppsV2()) {
     remoting.fullscreen = new remoting.FullscreenAppsV2();
     remoting.windowFrame = new remoting.WindowFrame(
         document.getElementById('title-bar'));
@@ skipping 33 matching lines @@
         document.getElementById('startup-mode-box-it2me').hidden = false;
       }
     };
     isWindowed_(onIsWindowed);
   }
 
   remoting.ClientPlugin.factory.preloadPlugin();
 
 }
 
+remoting.RemoteDesktop.prototype.onConnected = function() {
+  // Set the text on the buttons shown under the error message so that they are
+  // easy to understand in the case where a successful connection failed, as
+  // opposed to the case where a connection never succeeded.

[Jamie, 2014/12/04 22:56:58]

When does this get reverted? If we feel that we should show a different message
for connections that fail early on, then we should be resetting this message in
onDisconnected.

[garykac, 2014/12/05 19:55:40]

AFAICT, it doesn't get reverted. I've added a TODO.

+  var button1 = document.getElementById('client-reconnect-button');
+  l10n.localizeElementFromTag(button1, /*i18n-content*/'RECONNECT');
+  button1.removeAttribute('autofocus');
+  var button2 = document.getElementById('client-finished-me2me-button');
+  l10n.localizeElementFromTag(button2, /*i18n-content*/'OK');
+  button2.setAttribute('autofocus', 'autofocus');
+
+  document.getElementById('access-code-entry').value = '';
+  remoting.setMode(remoting.AppMode.IN_SESSION);
+  if (!base.isAppsV2()) {
+    remoting.toolbar.center();
+    remoting.toolbar.preview();
+  }
+};
+
+remoting.RemoteDesktop.prototype.onDisconnected = function() {
+};
+
+remoting.RemoteDesktop.prototype.onHostStarted = function() {
+};
+
+/**
+ * @param {remoting.Error} errorTag The error to be localized and displayed.
+ * @return {void} Nothing.
+ */
+remoting.RemoteDesktop.prototype.onError = function(errorTag) {
+  var errorDiv = document.getElementById('connect-error-message');
+  l10n.localizeElementFromTag(errorDiv, /** @type {string} */ (errorTag));
+
+  var mode = remoting.clientSession ? remoting.clientSession.getMode()
+                                    : remoting.connector.getConnectionMode();

[Jamie, 2014/12/04 22:56:58]

Would it make sense for the SessionConnector and ClientSession instances to be
members of the Application instance? An Application class is typically used to
scope variables that would otherwise be global, but it seems like that's not
quite the intent here, which makes me wonder if Application is the right name
for the base interface.

[garykac, 2014/12/05 19:55:40]

I was originally doing that in a separate cl, but I've moved the changes into
this one.

+  if (mode == remoting.ClientSession.Mode.IT2ME) {
+    remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_IT2ME);
+    remoting.hangoutSessionEvents.raiseEvent(
+        remoting.hangoutSessionEvents.sessionStateChanged,
+        remoting.ClientSession.State.FAILED
+    );
+  } else {
+    remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_ME2ME);
+  }
+};
+
 /**
  * Display the user's email address and allow access to the rest of the app,
  * including parsing URL parameters.
  *
  * @param {string} email The user's email address.
  * @return {void} Nothing.
  */
 remoting.onEmailAvailable = function(email, fullName) {
   document.getElementById('current-email').innerText = email;
   document.getElementById('get-started-it2me').disabled = false;
@@ skipping 149 matching lines @@
       console.log('Pairing registry not supported by host.');
       remoting.pairedClientManager.setPairedClients([]);
     }
   };
 
   remoting.hostController.hasFeature(
       remoting.HostController.Feature.PAIRING_REGISTRY, onHasFeatureResponse);
   remoting.hostController.getLocalHostState(onHostState);
 };
 
-window.addEventListener('load', remoting.initChromoting, false);
+/**
+ * Entry point ('load' handler) for Remote Desktop (CRD) webapp.
+ */
+remoting.initRemoteDesktop = function() {
+  remoting.app = new remoting.RemoteDesktop();
+  remoting.app.init();
+};
+
+window.addEventListener('load', remoting.initRemoteDesktop, false);