Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 7796022: Merge 94586 - REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on c... (Closed)

Created:
9 years, 1 month ago by Ilya Sherman
Modified:
9 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 94586 - REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium https://bugs.webkit.org/show_bug.cgi?id=67453 Reviewed by Kent Tamura. .: Add symbols for internals. * Source/autotools/symbols.filter: Source/WebCore: Fixed the bug by updating inner text value in setSuggestedValue. Also added a suggestedValue and setSuggestedValue on window.internals for testing purposes. Test: fast/forms/suggested-value.html * WebCore.exp.in: * testing/Internals.cpp: (WebCore::Internals::suggestedValue): (WebCore::Internals::setSuggestedValue): * testing/Internals.h: * testing/Internals.idl: Source/WebKit/chromium: Chromium code incorrectly calls Node::isFocusable without updating layout, and was hitting assertions. Fix the assertion failure (and a potential crash) by updating layout in WebCore::isFocusable. * src/WebNode.cpp: (WebKit::WebNode::isFocusable): Source/WebKit2: Add symbols for internals. * win/WebKit2.def: * win/WebKit2CFLite.def: LayoutTests: Added a regression test to ensure HTMLInputElement updates its inner text value when the suggested value is set. * fast/forms/suggested-value-expected.txt: Added. * fast/forms/suggested-value.html: Added. TBR=rniwa@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M ChangeLog View 1 chunk +11 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/suggested-value.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/suggested-value-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/WebCore.exp.in View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/html/HTMLInputElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/WebCore/testing/Internals.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit2/win/WebKit2.def View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKit2/win/WebKit2CFLite.def View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/autotools/symbols.filter View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ilya Sherman
9 years, 1 month ago (2011-09-09 22:59:10 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698