Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 7796020: Rename intents_settings_handler files to web_intents_settings_handler. (Closed)

Created:
9 years, 3 months ago by Greg Billock
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Rename intents_settings_handler files to web_intents_settings_handler. R=jhawkins@chromium.org BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101580

Patch Set 1 #

Patch Set 2 : Add IntentsModel to the rename #

Patch Set 3 : Merge to head #

Patch Set 4 : Merge to head #

Patch Set 5 : Squash change. The commit bots are really struggling. #

Patch Set 6 : Merge to head #

Patch Set 7 : Merge to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -850 lines) Patch
M chrome/browser/intents/web_intents_registry.h View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/intents/intents_model.h View 1 1 chunk +0 lines, -128 lines 0 comments Download
D chrome/browser/ui/intents/intents_model.cc View 1 1 chunk +0 lines, -162 lines 0 comments Download
D chrome/browser/ui/intents/intents_model_unittest.cc View 1 1 chunk +0 lines, -184 lines 0 comments Download
A + chrome/browser/ui/intents/web_intents_model.h View 1 6 chunks +23 lines, -23 lines 0 comments Download
A + chrome/browser/ui/intents/web_intents_model.cc View 1 7 chunks +34 lines, -33 lines 0 comments Download
A + chrome/browser/ui/intents/web_intents_model_unittest.cc View 1 5 chunks +23 lines, -23 lines 0 comments Download
D chrome/browser/ui/webui/options/intents_settings_handler.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/ui/webui/options/intents_settings_handler.cc View 1 2 1 chunk +0 lines, -161 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/web_intents_settings_handler.h View 1 4 chunks +17 lines, -17 lines 0 comments Download
A + chrome/browser/ui/webui/options/web_intents_settings_handler.cc View 1 2 5 chunks +33 lines, -33 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Greg Billock
9 years, 3 months ago (2011-09-09 22:42:23 UTC) #1
Greg Billock
On 2011/09/09 22:42:23, Greg Billock wrote: OK, Model rename now in.
9 years, 3 months ago (2011-09-12 18:11:07 UTC) #2
James Hawkins
LGTM
9 years, 3 months ago (2011-09-12 20:55:14 UTC) #3
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
9 years, 3 months ago (2011-09-12 23:57:04 UTC) #4
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
9 years, 3 months ago (2011-09-13 17:07:14 UTC) #5
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
9 years, 3 months ago (2011-09-13 18:05:07 UTC) #6
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
9 years, 3 months ago (2011-09-13 20:11:23 UTC) #7
commit-bot: I haz the power
Commit queue had an internal error. Something went really wrong, probably a crash, a hickup ...
9 years, 3 months ago (2011-09-13 23:29:29 UTC) #8
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/intents/web_intents_model.h. While running patch -p1 --forward --force; patching file chrome/browser/ui/intents/web_intents_model.h ...
9 years, 3 months ago (2011-09-14 17:11:51 UTC) #9
M-A Ruel
Looking at it.
9 years, 3 months ago (2011-09-14 17:12:24 UTC) #10
commit-bot: I haz the power
Can't apply patch for file chrome/chrome_browser.gypi. While running patch -p1 --forward --force; patching file chrome/chrome_browser.gypi ...
9 years, 3 months ago (2011-09-15 18:01:57 UTC) #11
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/intents/web_intents_model.h. While running patch -p1 --forward --force; patching file chrome/browser/ui/intents/web_intents_model.h ...
9 years, 3 months ago (2011-09-15 18:36:53 UTC) #12
M-A Ruel
9 years, 3 months ago (2011-09-15 18:37:29 UTC) #13
On 2011/09/15 18:36:53, I haz the power (commit-bot) wrote:
> Can't apply patch for file chrome/browser/ui/intents/web_intents_model.h.

(Not ready yet)

Powered by Google App Engine
This is Rietveld 408576698