Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

Issue 779593002: Move elementAccess() from namer to emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
diff --git a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
index 3cecbec34aa3cbd1edd18f7c60035530998a8aca..951e17686735652a7d9b5fcfa492c9152ae6b4ca 100644
--- a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
+++ b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
@@ -65,6 +65,22 @@ class CodeEmitterTask extends CompilerTask {
return emitter.constantReference(value);
}
+ jsAst.Expression staticFieldAccess(Element e) {
+ return emitter.staticFunctionAccess(e);
+ }
+
+ jsAst.Expression staticFunctionAccess(Element e) {
+ return emitter.staticFunctionAccess(e);
+ }
+
+ jsAst.Expression classAccess(Element e) {
+ return emitter.classAccess(e);
+ }
+
+ jsAst.Expression typedefAccess(Element e) {
+ return emitter.typedefAccess(e);
+ }
+
void registerReadTypeVariable(TypeVariableElement element) {
readTypeVariables.add(element);
}
@@ -354,6 +370,15 @@ abstract class Emitter {
jsAst.Expression generateEmbeddedGlobalAccess(String global);
jsAst.Expression constantReference(ConstantValue value);
+ jsAst.PropertyAccess staticFunctionAccess(Element element);
+
+ // TODO(zarah): Split into more fine-grained accesses
+ /// Generates access to the js constructor of the class represented by
+ /// [element]
+ jsAst.PropertyAccess classAccess(Element element);
+ jsAst.PropertyAccess typedefAccess(Element element);
+ jsAst.PropertyAccess staticFieldAccess(Element element);
+
int compareConstants(ConstantValue a, ConstantValue b);
bool isConstantInlinedOrAlreadyEmitted(ConstantValue constant);
« no previous file with comments | « pkg/compiler/lib/src/js_backend/runtime_types.dart ('k') | pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698