Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

Issue 779593002: Move elementAccess() from namer to emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
index 76f4fb8c388f97d4b690390f9067c320dd971e8a..826447a0047a97718ef258dbfd5ce3ddb054d818 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
@@ -126,7 +126,7 @@ class ContainerBuilder extends CodeEmitterHelper {
// `<class>.prototype.bar$1.call(this, argument0, ...)`.
body = js.statement(
'return #.prototype.#.call(this, #);',
- [backend.namer.elementAccess(superClass), methodName,
+ [backend.emitter.globalPropertyAccess(superClass), methodName,
floitsch 2014/12/03 17:02:25 prototypeAccess or classAccess.
zarah 2014/12/05 08:22:51 Done.
argumentsBuffer]);
} else {
body = js.statement(
@@ -135,7 +135,7 @@ class ContainerBuilder extends CodeEmitterHelper {
}
} else {
body = js.statement('return #(#)',
- [namer.elementAccess(member), argumentsBuffer]);
+ [emitter.globalPropertyAccess(member), argumentsBuffer]);
floitsch 2014/12/03 17:02:25 staticFunctionAccess
zarah 2014/12/05 08:22:51 Done.
}
jsAst.Fun function = js('function(#) { #; }', [parametersBuffer, body]);

Powered by Google App Engine
This is Rietveld 408576698