Introduce new API ariaAutoComplete() to expose correct state and object attribute.

Introduce new API ariaAutoComplete() to expose correct state and object attribute.

According to specs http://rawgit.com/w3c/aria/master/core-aam/core-aam.html
aria-autocomplete {"inline", "list","both"} set IA2_STATE_SUPPORTS_AUTOCOMPLETION.
aria-autocomplete {"none"} Not Mapped

Also expose object attribute autocomplete: <value>.

<div role="combobox" aria-autocomplete="inline"></div>
<div role="combobox" aria-autocomplete="list"></div>
<div role="combobox"aria-autocomplete="both"></div>
<div role="combobox" aria-autocomplete="none"></div>

AX Tree:
ROLE_SYSTEM_COMBOBOX IA2_STATE_SUPPORTS_AUTOCOMPLETION autocomplete:inline
ROLE_SYSTEM_COMBOBOX IA2_STATE_SUPPORTS_AUTOCOMPLETION autocomplete:list
ROLE_SYSTEM_COMBOBOX IA2_STATE_SUPPORTS_AUTOCOMPLETION autocomplete:both
ROLE_SYSTEM_COMBOBOX

BUG=169559, 169563
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186919

[shreeramk, 2014-12-08 17:08:16]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2014-12-08 17:08:17]

Please review.

thanks!!

[shreeramk, 2014-12-08 17:10:21]

shreeram.k@samsung.com changed reviewers:
+ mkwst@chromium.org

[shreeramk, 2014-12-08 17:10:21]

mkwst@chromium.org: Please review changes in web/ and HTMLAttributeNames.in

Thanks!1

[shreeramk, 2014-12-08 19:38:41]

shreeram.k@samsung.com changed reviewers:
+ aboxhall@chromium.org

[Mike West, 2014-12-09 14:12:02]

mkwst@chromium.org changed required reviewers:
+ dmazzoni@chromium.org

[Mike West, 2014-12-09 14:12:03]

web/ LGTM, but please wait for either Dominic or Alice to sign off on the change
before landing.

https://codereview.chromium.org/779513007/diff/1/Source/web/WebAXObject.cpp
File Source/web/WebAXObject.cpp (right):

https://codereview.chromium.org/779513007/diff/1/Source/web/WebAXObject.cpp#n...
Source/web/WebAXObject.cpp:227: return 0;
Noticed this in passing: would you mind putting together a followup CL to change
the return type to a boolean rather than casting from an int? It's ugly. :(

[dmazzoni, 2014-12-09 16:19:36]

https://codereview.chromium.org/779513007/diff/1/Source/modules/accessibility...
File Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/779513007/diff/1/Source/modules/accessibility...
Source/modules/accessibility/AXNodeObject.cpp:957: if (roleValue() ==
ComboBoxRole || roleValue() == TextAreaRole)
This test should come first so we don't need to call getAttribute only to throw
it away.

if (roleValue() != ComboBoxRole && roleValue() != TextAreaRole)
    return String();

Also, it's optional whether you want to have this return an enum or not, but I
think you should filter this to only valid attribute values.

I.e. if the value is "list", "inline", or "both", return the string - otherwise
return the empty string.

No need to return "none", since that's the same as no aria-autocomplete.

[shreeramk, 2014-12-10 05:10:10]

@Dominic: Comments Incorporated.
PTAL.
Thanks!

[dmazzoni, 2014-12-10 18:20:00]

lgtm

one more nit, then ok to land. thanks

https://codereview.chromium.org/779513007/diff/20001/Source/modules/accessibi...
File Source/modules/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/779513007/diff/20001/Source/modules/accessibi...
Source/modules/accessibility/AXNodeObject.cpp:961: if (ariaAutoComplete ==
"inline" || ariaAutoComplete == "list"
I think this needs to use equalsIgnoringCase instead of ==, either that or you
should convert ariaAutoComplete to lowercase first.

[shreeramk, 2014-12-11 05:18:09]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-12-11 05:18:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/779513007/40001

[commit-bot: I haz the power, 2014-12-11 06:16:54]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186919