Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Unified Diff: mojo/edk/system/simple_dispatcher.cc

Issue 779503003: Extract Awakable from Waiter (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Review Update Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/system/simple_dispatcher.cc
diff --git a/mojo/edk/system/simple_dispatcher.cc b/mojo/edk/system/simple_dispatcher.cc
index 3eb7a4f7990d200a4d8e518170cc27e89804baa9..e7b029b529b438fd9f6b51cc0de2b620047e29e8 100644
--- a/mojo/edk/system/simple_dispatcher.cc
+++ b/mojo/edk/system/simple_dispatcher.cc
@@ -17,16 +17,16 @@ SimpleDispatcher::~SimpleDispatcher() {
void SimpleDispatcher::HandleSignalsStateChangedNoLock() {
lock().AssertAcquired();
- waiter_list_.AwakeWaitersForStateChange(GetHandleSignalsStateImplNoLock());
+ awakable_list_.AwakeForStateChange(GetHandleSignalsStateImplNoLock());
}
-void SimpleDispatcher::CancelAllWaitersNoLock() {
+void SimpleDispatcher::CancelAllAwakablesNoLock() {
lock().AssertAcquired();
- waiter_list_.CancelAllWaiters();
+ awakable_list_.CancelAll();
}
-MojoResult SimpleDispatcher::AddWaiterImplNoLock(
- Waiter* waiter,
+MojoResult SimpleDispatcher::AddAwakableImplNoLock(
+ Awakable* awakable,
MojoHandleSignals signals,
uint32_t context,
HandleSignalsState* signals_state) {
@@ -44,15 +44,15 @@ MojoResult SimpleDispatcher::AddWaiterImplNoLock(
return MOJO_RESULT_FAILED_PRECONDITION;
}
- waiter_list_.AddWaiter(waiter, signals, context);
+ awakable_list_.AddWaiter(awakable, signals, context);
return MOJO_RESULT_OK;
}
-void SimpleDispatcher::RemoveWaiterImplNoLock(
- Waiter* waiter,
+void SimpleDispatcher::RemoveAwakableImplNoLock(
+ Awakable* awakable,
HandleSignalsState* signals_state) {
lock().AssertAcquired();
- waiter_list_.RemoveWaiter(waiter);
+ awakable_list_.RemoveWaiter(awakable);
if (signals_state)
*signals_state = GetHandleSignalsStateImplNoLock();
}

Powered by Google App Engine
This is Rietveld 408576698