Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 7795014: Mark DigiNotar as untrusted (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by agl
Modified:
3 years, 10 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Mark DigiNotar as untrusted BUG=94673 TEST=Visit https://www.diginotar.com and expect an invalid authority error. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98741

Patch Set 1 #

Total comments: 12

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M net/base/ev_root_ca_metadata.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M net/base/x509_certificate.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M net/base/x509_certificate.cc View 1 2 chunks +28 lines, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
wtc
LGTM, with the suggested changes below. http://codereview.chromium.org/7795014/diff/1/net/base/ev_root_ca_metadata.cc File net/base/ev_root_ca_metadata.cc (right): http://codereview.chromium.org/7795014/diff/1/net/base/ev_root_ca_metadata.cc#newcode279 net/base/ev_root_ca_metadata.cc:279: "2.16.528.1.1001.1.1.1.12.6.1.1.1", Please also ...
3 years, 10 months ago (2011-08-30 00:02:44 UTC) #1
agl
http://codereview.chromium.org/7795014/diff/1/net/base/ev_root_ca_metadata.cc File net/base/ev_root_ca_metadata.cc (right): http://codereview.chromium.org/7795014/diff/1/net/base/ev_root_ca_metadata.cc#newcode279 net/base/ev_root_ca_metadata.cc:279: "2.16.528.1.1001.1.1.1.12.6.1.1.1", On 2011/08/30 00:02:44, wtc wrote: > Please also ...
3 years, 10 months ago (2011-08-30 00:13:48 UTC) #2
wtc
3 years, 10 months ago (2011-08-30 00:19:23 UTC) #3
LGTM on Patch Set 2.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d