Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 779473002: gn format //third_party (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
CC:
chromium-reviews, jzern, sadrul, vikasa, skal, eme-reviews_chromium.org, urvang (Google), kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn format //third_party Uses gn binary at head. No intended functionality change. R=brettw@chromium.org TBR=scherkus@chromium.org BUG=348474 Committed: https://crrev.com/1c240d2719e764ed0108aa59ba35a6d99c00491a Cr-Commit-Position: refs/heads/master@{#306567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -448 lines) Patch
M third_party/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/adobe/flash/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/android_protobuf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/BUILD.gn View 5 chunks +9 lines, -12 lines 0 comments Download
M third_party/brotli/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/cld_2/BUILD.gn View 7 chunks +23 lines, -13 lines 0 comments Download
M third_party/cython/rules.gni View 5 chunks +23 lines, -22 lines 0 comments Download
M third_party/dom_distiller_js/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/elfutils/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/freetype2/BUILD.gn View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/google_input_tools/closure.gni View 1 chunk +21 lines, -12 lines 0 comments Download
M third_party/google_input_tools/inputview.gni View 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/iaccessible2/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/iccjpeg/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/isimpledom/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/jsoncpp/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/junit/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/BUILD.gn View 5 chunks +10 lines, -20 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 12 chunks +37 lines, -42 lines 0 comments Download
M third_party/libpng/BUILD.gn View 4 chunks +12 lines, -10 lines 0 comments Download
M third_party/libusb/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/libwebp/BUILD.gn View 7 chunks +50 lines, -64 lines 0 comments Download
M third_party/libxml/BUILD.gn View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/mesa/BUILD.gn View 6 chunks +45 lines, -58 lines 0 comments Download
M third_party/mozilla/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/npapi/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/opus/BUILD.gn View 6 chunks +19 lines, -26 lines 0 comments Download
M third_party/protobuf/BUILD.gn View 4 chunks +2 lines, -5 lines 0 comments Download
M third_party/protobuf/proto_library.gni View 2 chunks +23 lines, -10 lines 0 comments Download
M third_party/snappy/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/speex/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 4 chunks +10 lines, -2 lines 0 comments Download
M third_party/stp/BUILD.gn View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/usrsctp/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 4 chunks +14 lines, -18 lines 0 comments Download
M third_party/yasm/BUILD.gn View 13 chunks +88 lines, -46 lines 0 comments Download
M third_party/yasm/yasm_assemble.gni View 7 chunks +24 lines, -14 lines 0 comments Download
M third_party/zlib/BUILD.gn View 3 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
scottmg
6 years ago (2014-12-03 00:02:04 UTC) #1
urvang (Google)
lgtm LGTM for libwebp
6 years ago (2014-12-03 00:18:40 UTC) #3
brettw
lgtm
6 years ago (2014-12-03 07:12:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779473002/1
6 years ago (2014-12-03 07:16:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/27873)
6 years ago (2014-12-03 07:20:29 UTC) #8
scottmg
tbr scherkus for third_party/widevine/cdm/BUILD.gn (third_party/widevine/OWNERS is set noparent)
6 years ago (2014-12-03 07:24:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779473002/1
6 years ago (2014-12-03 07:25:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-03 07:28:09 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-03 07:29:53 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1c240d2719e764ed0108aa59ba35a6d99c00491a
Cr-Commit-Position: refs/heads/master@{#306567}

Powered by Google App Engine
This is Rietveld 408576698