Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 779463007: Add "meaning" attribute to conflicting string. (Closed)

Created:
6 years ago by newt (away)
Modified:
6 years ago
Reviewers:
aruslan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add "meaning" attribute to conflicting string. IDS_TRANSLATE_INFOBAR_TEXT in android_chrome_strings.grd is identical to to IDS_TRANSLATE_INFOBAR_BEFORE_MESSAGE_IOS in translate_strings.grdp, except for the values of the placeholders (^1 instead of $1). This causes errors in the translation pipeline (which expects identical strings to have identical placeholder values). This adds a "meaning" attribute to IDS_TRANSLATE_INFOBAR_TEXT which signals to the translation pipeline that these strings shouldn't be considered identical. BUG=438717 Committed: https://crrev.com/0b70de2223dfa96229a64f64c446eb3d362be625 Cr-Commit-Position: refs/heads/master@{#307320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
6 years ago (2014-12-08 19:28:59 UTC) #2
aruslan
lgtm
6 years ago (2014-12-08 19:30:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779463007/1
6 years ago (2014-12-08 19:45:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 20:28:15 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-08 20:29:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b70de2223dfa96229a64f64c446eb3d362be625
Cr-Commit-Position: refs/heads/master@{#307320}

Powered by Google App Engine
This is Rietveld 408576698