Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 779433003: MIPS: Fix ambiguous double constant loading after adding checked load/store operators. (Closed)

Created:
6 years ago by dusmil.imgtec
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix ambiguous double constant loading after adding checked load/store operators. The V8_INFINITY macro expands to constant expression of type float. TEST=mjsunit/constant-folding-2 BUG= R=balazs.kilvady@imgtec.com Committed: https://chromium.googlesource.com/v8/v8/+/57957b480c1e47fb01326b8bb437c6b88a0a1405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/mips/code-stubs-mips.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
dusmil.imgtec
6 years ago (2014-12-03 11:11:37 UTC) #2
balazs.kilvady
lgtm
6 years ago (2014-12-03 11:41:58 UTC) #3
dusmil.imgtec
6 years ago (2014-12-03 12:51:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57957b480c1e47fb01326b8bb437c6b88a0a1405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698