Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: Source/core/loader/DocumentWriter.cpp

Issue 779393002: Turn DocumentParser::pinToMainThread into a cleaner api (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/loader/DocumentWriter.h ('k') | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010. Adam Barth. All rights reserved. 2 * Copyright (C) 2010. Adam Barth. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 26 matching lines...) Expand all
37 #include "core/frame/Settings.h" 37 #include "core/frame/Settings.h"
38 #include "core/html/parser/TextResourceDecoder.h" 38 #include "core/html/parser/TextResourceDecoder.h"
39 #include "core/loader/FrameLoader.h" 39 #include "core/loader/FrameLoader.h"
40 #include "core/loader/FrameLoaderStateMachine.h" 40 #include "core/loader/FrameLoaderStateMachine.h"
41 #include "platform/weborigin/KURL.h" 41 #include "platform/weborigin/KURL.h"
42 #include "platform/weborigin/SecurityOrigin.h" 42 #include "platform/weborigin/SecurityOrigin.h"
43 #include "wtf/PassOwnPtr.h" 43 #include "wtf/PassOwnPtr.h"
44 44
45 namespace blink { 45 namespace blink {
46 46
47 PassRefPtrWillBeRawPtr<DocumentWriter> DocumentWriter::create(Document* document , const AtomicString& mimeType, const AtomicString& encoding) 47 PassRefPtrWillBeRawPtr<DocumentWriter> DocumentWriter::create(Document* document , ParserSynchronizationPolicy parsingPolicy, const AtomicString& mimeType, const AtomicString& encoding)
48 { 48 {
49 return adoptRefWillBeNoop(new DocumentWriter(document, mimeType, encoding)); 49 return adoptRefWillBeNoop(new DocumentWriter(document, parsingPolicy, mimeTy pe, encoding));
50 } 50 }
51 51
52 DocumentWriter::DocumentWriter(Document* document, const AtomicString& mimeType, const AtomicString& encoding) 52 DocumentWriter::DocumentWriter(Document* document, ParserSynchronizationPolicy p arserSyncPolicy, const AtomicString& mimeType, const AtomicString& encoding)
53 : m_document(document) 53 : m_document(document)
54 , m_decoderBuilder(mimeType, encoding) 54 , m_decoderBuilder(mimeType, encoding)
55 // We grab a reference to the parser so that we'll always send data to the 55 // We grab a reference to the parser so that we'll always send data to the
56 // original parser, even if the document acquires a new parser (e.g., via 56 // original parser, even if the document acquires a new parser (e.g., via
57 // document.open). 57 // document.open).
58 , m_parser(m_document->implicitOpen()) 58 , m_parser(m_document->implicitOpen(parserSyncPolicy))
59 , m_forcedSynchronousParse(false)
60 { 59 {
61 if (m_document->frame()) { 60 if (m_document->frame()) {
62 if (FrameView* view = m_document->frame()->view()) 61 if (FrameView* view = m_document->frame()->view())
63 view->setContentsSize(IntSize()); 62 view->setContentsSize(IntSize());
64 } 63 }
65 } 64 }
66 65
67 DocumentWriter::~DocumentWriter() 66 DocumentWriter::~DocumentWriter()
68 { 67 {
69 } 68 }
70 69
71 void DocumentWriter::trace(Visitor* visitor) 70 void DocumentWriter::trace(Visitor* visitor)
72 { 71 {
73 visitor->trace(m_document); 72 visitor->trace(m_document);
74 visitor->trace(m_parser); 73 visitor->trace(m_parser);
75 } 74 }
76 75
77 void DocumentWriter::forceSynchronousParse()
78 {
79 ASSERT(!m_forcedSynchronousParse);
80
81 ASSERT(m_parser);
82 m_parser->pinToMainThread();
83 m_forcedSynchronousParse = true;
84 }
85
86 void DocumentWriter::appendReplacingData(const String& source) 76 void DocumentWriter::appendReplacingData(const String& source)
87 { 77 {
88 m_document->setCompatibilityMode(Document::NoQuirksMode); 78 m_document->setCompatibilityMode(Document::NoQuirksMode);
89 79
90 // FIXME: This should call DocumentParser::appendBytes instead of append 80 // FIXME: This should call DocumentParser::appendBytes instead of append
91 // to support RawDataDocumentParsers. 81 // to support RawDataDocumentParsers.
92 if (DocumentParser* parser = m_document->parser()) { 82 if (DocumentParser* parser = m_document->parser()) {
93 if (!m_forcedSynchronousParse) 83 // Because the parser is pinned to the main thread we don't need to worr y about
94 forceSynchronousParse();
95 // Because we're pinned to the main thread we don't need to worry about
96 // passing ownership of the source string. 84 // passing ownership of the source string.
97 parser->append(source.impl()); 85 parser->append(source.impl());
98 } 86 }
99 } 87 }
100 88
101 void DocumentWriter::addData(const char* bytes, size_t length) 89 void DocumentWriter::addData(const char* bytes, size_t length)
102 { 90 {
103 ASSERT(m_parser); 91 ASSERT(m_parser);
104 if (m_parser->needsDecoder() && 0 < length) { 92 if (m_parser->needsDecoder() && 0 < length) {
105 OwnPtr<TextResourceDecoder> decoder = m_decoderBuilder.buildFor(m_docume nt); 93 OwnPtr<TextResourceDecoder> decoder = m_decoderBuilder.buildFor(m_docume nt);
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 decoder->setEncoding(charset, TextResourceDecoder::UserChosenEncoding); 129 decoder->setEncoding(charset, TextResourceDecoder::UserChosenEncoding);
142 } 130 }
143 131
144 void DocumentWriter::setDocumentWasLoadedAsPartOfNavigation() 132 void DocumentWriter::setDocumentWasLoadedAsPartOfNavigation()
145 { 133 {
146 ASSERT(m_parser && !m_parser->isStopped()); 134 ASSERT(m_parser && !m_parser->isStopped());
147 m_parser->setDocumentWasLoadedAsPartOfNavigation(); 135 m_parser->setDocumentWasLoadedAsPartOfNavigation();
148 } 136 }
149 137
150 } // namespace blink 138 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/loader/DocumentWriter.h ('k') | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698