Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: Source/core/dom/DocumentParser.h

Issue 779393002: Turn DocumentParser::pinToMainThread into a cleaner api (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/html/TextDocument.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Peter Kelly (pmk@post.com) 2 * Copyright (C) 2000 Peter Kelly (pmk@post.com)
3 * Copyright (C) 2005, 2006 Apple Computer, Inc. 3 * Copyright (C) 2005, 2006 Apple Computer, Inc.
4 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 4 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
5 * Copyright (C) 2010 Google, Inc. 5 * Copyright (C) 2010 Google, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // insert is used by document.write. 49 // insert is used by document.write.
50 virtual void insert(const SegmentedString&) = 0; 50 virtual void insert(const SegmentedString&) = 0;
51 51
52 // The below functions are used by DocumentWriter (the loader). 52 // The below functions are used by DocumentWriter (the loader).
53 virtual void appendBytes(const char* bytes, size_t length) = 0; 53 virtual void appendBytes(const char* bytes, size_t length) = 0;
54 virtual bool needsDecoder() const { return false; } 54 virtual bool needsDecoder() const { return false; }
55 virtual void setDecoder(PassOwnPtr<TextResourceDecoder>); 55 virtual void setDecoder(PassOwnPtr<TextResourceDecoder>);
56 virtual TextResourceDecoder* decoder(); 56 virtual TextResourceDecoder* decoder();
57 virtual void setHasAppendedData() { } 57 virtual void setHasAppendedData() { }
58 58
59 // pinToMainThread also makes append() not yield before completion of that c hunk.
60 virtual void pinToMainThread() { }
61
62 // FIXME: append() should be private, but DocumentLoader::replaceDocumentWhi leExecutingJavaScriptURL uses it for now. 59 // FIXME: append() should be private, but DocumentLoader::replaceDocumentWhi leExecutingJavaScriptURL uses it for now.
63 // FIXME: This really should take a PassOwnPtr to signify that it expects to take 60 // FIXME: This really should take a PassOwnPtr to signify that it expects to take
64 // ownership of the buffer. The parser expects the PassRefPtr to hold the on ly ref of the StringImpl. 61 // ownership of the buffer. The parser expects the PassRefPtr to hold the on ly ref of the StringImpl.
65 virtual void append(PassRefPtr<StringImpl>) = 0; 62 virtual void append(PassRefPtr<StringImpl>) = 0;
66 63
67 virtual void finish() = 0; 64 virtual void finish() = 0;
68 65
69 // FIXME: processingData() is only used by DocumentLoader::isLoadingInAPISen se 66 // FIXME: processingData() is only used by DocumentLoader::isLoadingInAPISen se
70 // and is very unclear as to what it actually means. The LegacyHTMLDocument Parser 67 // and is very unclear as to what it actually means. The LegacyHTMLDocument Parser
71 // used to implement it. 68 // used to implement it.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 // Every DocumentParser needs a pointer back to the document. 122 // Every DocumentParser needs a pointer back to the document.
126 // m_document will be 0 after the parser is stopped. 123 // m_document will be 0 after the parser is stopped.
127 RawPtrWillBeMember<Document> m_document; 124 RawPtrWillBeMember<Document> m_document;
128 125
129 WillBeHeapHashSet<RawPtrWillBeWeakMember<DocumentParserClient> > m_clients; 126 WillBeHeapHashSet<RawPtrWillBeWeakMember<DocumentParserClient> > m_clients;
130 }; 127 };
131 128
132 } // namespace blink 129 } // namespace blink
133 130
134 #endif // DocumentParser_h 131 #endif // DocumentParser_h
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/html/TextDocument.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698