Turn DocumentParser::pinToMainThread into a cleaner api

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 490 matching lines @@
     , m_writeRecursionIsTooDeep(false)
     , m_writeRecursionDepth(0)
     , m_taskRunner(MainThreadTaskRunner::create(this))
     , m_registrationContext(initializer.registrationContext(this))
     , m_elementDataCacheClearTimer(this, &Document::elementDataCacheClearTimerFired)
     , m_timeline(AnimationTimeline::create(this))
     , m_templateDocumentHost(nullptr)
     , m_didAssociateFormControlsTimer(this, &Document::didAssociateFormControlsTimerFired)
     , m_hasViewportUnits(false)
     , m_styleRecalcElementCounter(0)
+    , m_backgroundParsingPolicy(AllowAsynchronousParsing)
 {
     if (m_frame) {
         ASSERT(m_frame->page());
         provideContextFeaturesToDocumentFrom(*this, *m_frame->page());
 
         m_fetcher = m_frame->loader().documentLoader()->fetcher();
     }
 
     if (!m_fetcher)
         m_fetcher = ResourceFetcher::create(0);
@@ skipping 705 matching lines @@
 }
 
 KURL Document::baseURI() const
 {
     return m_baseURL;
 }
 
 void Document::setContent(const String& content)
 {
     open();
-    // FIXME: This should probably use insert(), but that's (intentionally)
-    // not implemented for the XML parser as it's normally synonymous with
-    // document.write(). append() will end up yielding, but close() will
-    // pump the tokenizer syncrhonously and finish the parse.
-    m_parser->pinToMainThread();

[kbalazs, 2014/12/05 23:37:57]

Note that this called XMLDocumentParser::pinToMainThread which is noop.

About the yeilding mentioned in the comment that does not happen for synchronous
parsing which is enforced by using open() instead of implicitOpen(). And this
should not use insert for sure because insert is only for document.write.

     m_parser->append(content.impl());
     close();
 }
 
 String Document::suggestedMIMEType() const
 {
     if (isXMLDocument()) {
         if (isXHTMLDocument())
             return "application/xhtml+xml";
         if (isSVGDocument())
@@ skipping 1030 matching lines @@
     ASSERT(&cacheOwner == this || !m_axObjectCache);
     if (!cacheOwner.m_axObjectCache)
         cacheOwner.m_axObjectCache = adoptPtr(AXObjectCache::create(cacheOwner));
     return cacheOwner.m_axObjectCache.get();
 }
 
 PassRefPtrWillBeRawPtr<DocumentParser> Document::createParser()
 {
     if (isHTMLDocument()) {
         bool reportErrors = InspectorInstrumentation::collectingHTMLParseErrors(page());
-        return HTMLDocumentParser::create(toHTMLDocument(*this), reportErrors);
+        return HTMLDocumentParser::create(toHTMLDocument(*this), reportErrors, m_backgroundParsingPolicy);
     }
     // FIXME: this should probably pass the frame instead
     return XMLDocumentParser::create(*this, view());
 }
 
 bool Document::isFrameSet() const
 {
     if (!isHTMLDocument())
         return false;
     return isHTMLFrameSetElement(body());
@@ skipping 26 matching lines @@
 
                 if (!parser->wasCreatedByScript() && parser->hasInsertionPoint())
                     return;
             }
         }
 
         if (m_frame->loader().state() == FrameStateProvisional)
             m_frame->loader().stopAllLoaders();
     }
 
+    forceSynchronousParsing();

[kbalazs, 2014/12/05 23:37:57]

This is in open() (not obvious from the context).

+
     removeAllEventListenersRecursively();
     implicitOpen();
     if (ScriptableDocumentParser* parser = scriptableDocumentParser())
         parser->setWasCreatedByScript(true);
 
     if (m_frame)
         m_frame->loader().didExplicitOpen();
     if (m_loadEventProgress != LoadEventInProgress && m_loadEventProgress != UnloadEventInProgress)
         m_loadEventProgress = LoadEventNotRun;
 }
 
+void Document::forceSynchronousParsing()
+{
+    ASSERT(!m_parser);
+    m_backgroundParsingPolicy = ForceSynchronousParsing;
+}
+
 void Document::detachParser()
 {
     if (!m_parser)
         return;
     m_parser->detach();
     m_parser.clear();
 }
 
 void Document::cancelParsing()
 {
@@ skipping 3464 matching lines @@
 #ifndef NDEBUG
 using namespace blink;
 void showLiveDocumentInstances()
 {
     WeakDocumentSet& set = liveDocumentSet();
     fprintf(stderr, "There are %u documents currently alive:\n", set.size());
     for (Document* document : set)
         fprintf(stderr, "- Document %p URL: %s\n", document, document->url().string().utf8().data());
 }
 #endif