Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: tools/telemetry/telemetry/user_story/user_story_set_unittest.py

Issue 779383002: Move WPR-related attributes to UserStorySet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/user_story/user_story_set_unittest.py
diff --git a/tools/telemetry/telemetry/user_story/user_story_test_unittest.py b/tools/telemetry/telemetry/user_story/user_story_set_unittest.py
similarity index 36%
rename from tools/telemetry/telemetry/user_story/user_story_test_unittest.py
rename to tools/telemetry/telemetry/user_story/user_story_set_unittest.py
index b855d9b85e78dc53a29b686eb6b8cdde39e1a2bd..be7d10380f16e20ac85f1655c4f296910948f42c 100644
--- a/tools/telemetry/telemetry/user_story/user_story_test_unittest.py
+++ b/tools/telemetry/telemetry/user_story/user_story_set_unittest.py
@@ -2,9 +2,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import os
import unittest
from telemetry.user_story import user_story_set
+from telemetry.util import cloud_storage
class UserStorySetFoo(user_story_set.UserStorySet):
@@ -15,9 +17,34 @@ class UserStorySetFoo(user_story_set.UserStorySet):
class UserStorySetTest(unittest.TestCase):
def testUserStoryTestName(self):
- self.assertEquals('user_story_test_unittest', UserStorySetFoo.Name())
+ self.assertEquals('user_story_set_unittest', UserStorySetFoo.Name())
def testUserStoryTestDescription(self):
self.assertEquals(
' UserStorySetFoo is a user story created for testing purpose. ',
UserStorySetFoo.Description())
+
+ def testBaseDir(self):
+ uss = UserStorySetFoo()
+ base_dir = uss.base_dir
+ self.assertTrue(os.path.isdir(base_dir))
+ self.assertEqual(base_dir, os.path.dirname(__file__))
+
+ def testCloudBucket(self):
+ blank_uss = user_story_set.UserStorySet()
+ self.assertEqual(blank_uss.bucket, None)
+
+ public_uss = user_story_set.UserStorySet(
+ cloud_storage_bucket=cloud_storage.PUBLIC_BUCKET)
+ self.assertEqual(public_uss.bucket, cloud_storage.PUBLIC_BUCKET)
+
+ partner_uss = user_story_set.UserStorySet(
+ cloud_storage_bucket=cloud_storage.PARTNER_BUCKET)
+ self.assertEqual(partner_uss.bucket, cloud_storage.PARTNER_BUCKET)
+
+ internal_uss = user_story_set.UserStorySet(
+ cloud_storage_bucket=cloud_storage.INTERNAL_BUCKET)
+ self.assertEqual(internal_uss.bucket, cloud_storage.INTERNAL_BUCKET)
+
+ self.assertRaises(ValueError, user_story_set.UserStorySet,
+ cloud_storage_bucket='garbage_bucket')

Powered by Google App Engine
This is Rietveld 408576698