Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 779203005: Make sure that individual shipping features can be disabled. (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Make sure that individual shipping features can be disabled. R=rossberg@chromium.org

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M src/flag-definitions.h View 5 chunks +14 lines, -3 lines 0 comments Download
A + test/mjsunit/harmony/disable-harmony-string.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dmitry Lomov (no reviews)
PTAL. I realized that implications trump specifying a flag on command line, So before this ...
6 years ago (2014-12-05 14:55:39 UTC) #1
Dmitry Lomov (no reviews)
Added a test
6 years ago (2014-12-05 14:57:23 UTC) #2
rossberg
lgtm
6 years ago (2014-12-05 15:04:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779203005/20001
6 years ago (2014-12-05 15:04:22 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-05 15:35:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698