components/password_manager/core/browser/login_database.cc - Issue 779183003: LoginDatabase should allow retrieveing credentials with IP addresses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 779183003: LoginDatabase should allow retrieveing credentials with IP addresses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing tests Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/login_database.cc

diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc

index a3f1c9b27b9e10899003ec506abc5cafb412d321..1005cc22c47ef0e2dbbe798136e13371fe5de25d 100644

--- a/components/password_manager/core/browser/login_database.cc

+++ b/components/password_manager/core/browser/login_database.cc

@@ -659,6 +659,7 @@ bool LoginDatabase::GetLogins(const PasswordForm& form,

std::string registered_domain = GetRegistryControlledDomain(signon_realm);

PSLDomainMatchMetric psl_domain_match_metric = PSL_DOMAIN_MATCH_NONE;

const bool should_PSL_matching_apply =

+ form.scheme == PasswordForm::SCHEME_HTML &&

ShouldPSLDomainMatchingApply(registered_domain);

// PSL matching only applies to HTML forms.

if (form.scheme == PasswordForm::SCHEME_HTML && should_PSL_matching_apply) {

Garrett Casto 2014/12/05 19:12:38 Scheme check here is no longer necessary.

vabr (Chromium) 2014/12/05 22:22:51 Done.

« no previous file with comments | « no previous file | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »