LoginDatabase should allow retrieveing credentials with IP addresses

LoginDatabase should allow retrieveing credentials with IP addresses

Currently, when a credential for an IP-specified host is saved in
the LoginDatabase, it cannot be retrieved, because it is subjected
to the PSL matching check, and that fails for IP addresses.

The reason is that IP addresses cannot be PSL matched (there is no
subdomain structure to meaningfully match against).

This CL makes sure, that PSL matching for IP addresses reduces
to identity checking. Also, it makes sute that the LoginDatabase
does not even attempt PSL matching on non-HTML forms (PSL
matching is not intended for those).

BUG=423327
Committed: https://crrev.com/71c5a60d9723bc4b8255177cf0dc60b9c750a908
Cr-Commit-Position: refs/heads/master@{#307107}

[vabr (Chromium), 2014-12-05 15:56:17]

vabr@chromium.org changed reviewers:
+ gcasto@chromium.org

[vabr (Chromium), 2014-12-05 15:56:18]

Hi Garrett,

PTAL.

(I checked that the added test fails without the fix.)

Cheers,
Vaclav

[Garrett Casto, 2014-12-05 19:12:38]

LGTM

I think that it would also make sense to return false from
ShouldPSLMatchingApply() if the registry controlled domain is empty, which
should be true for IP addresses
(https://code.google.com/p/chromium/codesearch#chromium/src/net/base/registry_...).
Just seems intuitive that PSL matching shouldn't apply in these cases.

https://codereview.chromium.org/779183003/diff/20001/components/password_mana...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/779183003/diff/20001/components/password_mana...
components/password_manager/core/browser/login_database.cc:665: if (form.scheme
== PasswordForm::SCHEME_HTML && should_PSL_matching_apply) {
Scheme check here is no longer necessary.

[vabr (Chromium), 2014-12-05 22:22:51]

Thanks, Garrett.

I addressed both your comments, and will be sending to CQ now.

Cheers,
Vaclav

https://codereview.chromium.org/779183003/diff/20001/components/password_mana...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/779183003/diff/20001/components/password_mana...
components/password_manager/core/browser/login_database.cc:665: if (form.scheme
== PasswordForm::SCHEME_HTML && should_PSL_matching_apply) {
On 2014/12/05 19:12:38, Garrett Casto wrote:
> Scheme check here is no longer necessary.

Done.

[vabr (Chromium), 2014-12-05 22:22:56]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2014-12-05 22:24:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/779183003/40001

[commit-bot: I haz the power, 2014-12-05 23:26:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-05 23:27:15]

Patchset 3 (id:??) landed as
https://crrev.com/71c5a60d9723bc4b8255177cf0dc60b9c750a908
Cr-Commit-Position: refs/heads/master@{#307107}