Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: src/isolate.h

Issue 77913003: Make it possible to add more than one piece of embedder data to isolates (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index 1d45de97b8ee88009c9aa8d3183ecc5a3dbbb0d3..77e4595b72e324a4ee29450422b849cf907c8002 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -1050,8 +1050,8 @@ class Isolate {
thread_local_top_.current_vm_state_ = state;
}
- void SetData(void* data) { embedder_data_ = data; }
- void* GetData() { return embedder_data_; }
+ void SetData(uint32_t slot, void* data) { embedder_data_[slot] = data; }
Sven Panne 2013/11/20 10:03:02 An ASSERT that slot is in range might be nice here
+ void* GetData(uint32_t slot) { return embedder_data_[slot]; }
LookupResult* top_lookup_result() {
return thread_local_top_.top_lookup_result_;
@@ -1165,7 +1165,7 @@ class Isolate {
// with v8::internal::Internals (in include/v8.h) constants. This is also
// verified in Isolate::Init() using runtime checks.
State state_; // Will be padded to kApiPointerSize.
- void* embedder_data_;
+ void* embedder_data_[Internals::kNumIsolateDataSlots];
Heap heap_;
// The per-process lock should be acquired before the ThreadDataTable is

Powered by Google App Engine
This is Rietveld 408576698