Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 77913002: [SyncFS] Implement non-conflict local folder addition. (Closed)

Created:
7 years, 1 month ago by tzik
Modified:
7 years, 1 month ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, nhiroki+watch_chromium.org, kinuko+watch, tzik, keishi
Visibility:
Public.

Description

[SyncFS] Implement non-conflict local folder addition. * Handles local folder addition to existing remote file. * Add MarkTrackerDirty to MetadataDatabase. * Reorder GetRegisteredAppIDs BUG=240165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236243

Patch Set 1 #

Patch Set 2 : +MarkTrackerDirty impl #

Total comments: 2

Patch Set 3 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -20 lines) Patch
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 1 2 1 chunk +30 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 1 3 chunks +34 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
PTL
7 years, 1 month ago (2013-11-20 09:05:26 UTC) #1
kinuko
lgtm
7 years, 1 month ago (2013-11-20 10:42:21 UTC) #2
nhiroki
lgtm https://codereview.chromium.org/77913002/diff/20001/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc File chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc (right): https://codereview.chromium.org/77913002/diff/20001/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc#newcode195 chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc:195: // TODO(tzik): Delete remote file and create an ...
7 years, 1 month ago (2013-11-20 11:33:10 UTC) #3
tzik
Thanks! https://codereview.chromium.org/77913002/diff/20001/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc File chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc (right): https://codereview.chromium.org/77913002/diff/20001/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc#newcode195 chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc:195: // TODO(tzik): Delete remote file and create an ...
7 years, 1 month ago (2013-11-20 11:57:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/77913002/80001
7 years, 1 month ago (2013-11-20 11:57:50 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 14:03:10 UTC) #6
Message was sent while issue was closed.
Change committed as 236243

Powered by Google App Engine
This is Rietveld 408576698