Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: runtime/bin/vmservice/observatory/test/graph_test.dart

Issue 779103003: Fix bugs in heapmap, binary payloads, 'address' request. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/observatory/test/graph_test.dart
===================================================================
--- runtime/bin/vmservice/observatory/test/graph_test.dart (revision 42116)
+++ runtime/bin/vmservice/observatory/test/graph_test.dart (working copy)
@@ -86,11 +86,8 @@
});
return isolate.rootLib.load().then((Library lib) {
expect(lib.classes.length, equals(1));
- // TODO(koda): Use vmCid.
Class fooClass = lib.classes.first;
- String prefix = "classes/";
- // TODO(koda): Add method on Class to get numerical id.
- fooId = int.parse(fooClass.id.substring(prefix.length));
+ fooId = fooClass.vmCid;
isolate.get('graph');
return completer.future;
});
« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698