runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart - Issue 779103003: Fix bugs in heapmap, binary payloads, 'address' request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart

Issue 779103003: Fix bugs in heapmap, binary payloads, 'address' request. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/service_html.dart ('k') | runtime/bin/vmservice/observatory/test/graph_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart

===================================================================

--- runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart (revision 42116)

+++ runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart (working copy)

@@ -155,7 +155,7 @@

void _handleClick(MouseEvent event) {

var address = _objectAt(event.offset).address.toRadixString(16);

- window.location.hash = "/${fragmentation.isolate.link}/address/$address";

+ window.location.hash = "${fragmentation.isolate.link}/address/$address";

Cutch 2014/12/08 18:24:47 You shouldn't be touching the window.location.hash

koda 2014/12/08 18:36:57 Done.

}

void _updateFragmentationData() {

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/service_html.dart ('k') | runtime/bin/vmservice/observatory/test/graph_test.dart » ('j') | no next file with comments »