Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 779103002: Revert of Various changes required to support ChromeVox Next to read Views and Windows. (Closed)

Created:
6 years ago by jonross
Modified:
6 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Various changes required to support ChromeVox Next to read Views and Windows. (patchset #13 id:240001 of https://codereview.chromium.org/743273002/) Reason for revert: This change broken the ChromiumOS on Chromium build: http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/3342 With the error: chrome/browser/ui/ash/accessibility/ax_root_obj_wrapper.h:17:7: error: 'AXRootObjWrapper' has a field 'AXRootObjWrapper::alert_window_' whose type uses the anonymous namespace [-Werror] Original issue's description: > Various changes required to support ChromeVox Next to read Views and Windows. > > - adds support for valueChanged event (e.g. to read adjustment of the volume slider) > - add textChanged event handler to process omnibox character echo/deletion. > - braille support for the textChanged,textSelectionChanged events > - whitelist ChromeVox for automation API up to stable. > - remove the --enable-chromevox-next cmd line flag. > - adds options for Output module (to only output braille, for example). > - adds a "dummy" alert window as a child of the desktop root node; this window will be used to fire alert events. Due to the way we support alerts now without backing views, this is necessary. > - start generating context for window on "enter". This picks up announcements like "status tray" when entering the status tray bar with alt+shift+s. > - exclude the first child (only child) of the desktop node from having a name set; this is because that particular window has a non-human readable name "Display<xxx>" which gets read frequently when entering a screen/display. > > Committed: https://crrev.com/113aa4f1f3e207b4b134ecc7316b9c46e29a22ad > Cr-Commit-Position: refs/heads/master@{#306855} TBR=dmazzoni@chromium.org,plundblad@chromium.org,kalman@chromium.org,zelidrag@chromium.org,oshima@chromium.org,dtseng@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b61d27f746c95843d107516a733f93e6d52ca26a Cr-Commit-Position: refs/heads/master@{#306868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -172 lines) Patch
M chrome/browser/chromeos/input_method/accessibility.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gyp View 3 chunks +26 lines, -18 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js View 1 chunk +15 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 7 chunks +7 lines, -31 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 5 chunks +4 lines, -16 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/accessibility/automation_manager_ash.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/accessibility/automation_manager_ash.cc View 3 chunks +4 lines, -15 lines 0 comments Download
M chrome/browser/ui/ash/accessibility/ax_root_obj_wrapper.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/accessibility/ax_root_obj_wrapper.cc View 2 chunks +2 lines, -27 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/accessibility/ax_window_obj_wrapper.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jonross
Created Revert of Various changes required to support ChromeVox Next to read Views and Windows.
6 years ago (2014-12-04 19:22:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779103002/1
6 years ago (2014-12-04 19:23:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-04 19:24:27 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-04 19:25:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b61d27f746c95843d107516a733f93e6d52ca26a
Cr-Commit-Position: refs/heads/master@{#306868}

Powered by Google App Engine
This is Rietveld 408576698