Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: sync/internal_api/public/sync_encryption_handler.h

Issue 779093002: Add the Sync.PassphraseType histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/internal_api/sync_encryption_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/sync_encryption_handler.h
diff --git a/sync/internal_api/public/sync_encryption_handler.h b/sync/internal_api/public/sync_encryption_handler.h
index cd1cfc04f02c498f5972abab79dd363584ce3cdf..bf5a6efe80c1061b0b24169db0cd5573bef6c76a 100644
--- a/sync/internal_api/public/sync_encryption_handler.h
+++ b/sync/internal_api/public/sync_encryption_handler.h
@@ -33,11 +33,14 @@ enum PassphraseRequiredReason {
// The different states for the encryption passphrase. These control if and how
// the user should be prompted for a decryption passphrase.
+// Do not re-order or delete these entries; they are used in a UMA histogram.
+// Please edit SyncPassphraseType in histograms.xml if a value is added.
enum PassphraseType {
IMPLICIT_PASSPHRASE = 0, // GAIA-based passphrase (deprecated).
KEYSTORE_PASSPHRASE = 1, // Keystore passphrase.
FROZEN_IMPLICIT_PASSPHRASE = 2, // Frozen GAIA passphrase.
CUSTOM_PASSPHRASE = 3, // User-provided passphrase.
+ PASSPHRASE_TYPE_SIZE, // The size of this enum; keep last.
};
// Enum used to distinguish which bootstrap encryption token is being updated.
« no previous file with comments | « no previous file | sync/internal_api/sync_encryption_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698