Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 779063003: Move //services/clipboard code out of namespace mojo (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
Reviewers:
Elliot Glaysher
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Move //services/clipboard code out of namespace mojo Now that the code doesn't live under //mojo/services/ it doesn't make sense for the types to exist in namespace mojo. R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e2f296aa83dec357ed3ce6b7ac951d5b7ac56f23

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -37 lines) Patch
M services/clipboard/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/clipboard/clipboard_apptest.cc View 7 chunks +24 lines, -21 lines 1 comment Download
M services/clipboard/clipboard_standalone_impl.h View 4 chunks +7 lines, -7 lines 0 comments Download
M services/clipboard/clipboard_standalone_impl.cc View 3 chunks +16 lines, -8 lines 0 comments Download
M services/clipboard/main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
6 years ago (2014-12-04 23:11:54 UTC) #1
jamesr
Could also go with 'namespace clipboard', and 'namespace foo' for //services/foo.
6 years ago (2014-12-04 23:12:54 UTC) #2
Elliot Glaysher
lgtm https://codereview.chromium.org/779063003/diff/1/services/clipboard/clipboard_apptest.cc File services/clipboard/clipboard_apptest.cc (right): https://codereview.chromium.org/779063003/diff/1/services/clipboard/clipboard_apptest.cc#newcode46 services/clipboard/clipboard_apptest.cc:46: using mojo::String; This should be above the anonymous ...
6 years ago (2014-12-04 23:16:27 UTC) #3
jamesr
Thanks, that's better. I'm leaning towards 'namespace clipboard'
6 years ago (2014-12-04 23:49:40 UTC) #4
jamesr
6 years ago (2014-12-05 19:16:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2f296aa83dec357ed3ce6b7ac951d5b7ac56f23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698