Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 779053002: Support checking RsnFlags as well as WpaFlags so that security type is reported correctly for all n… (Closed)

Created:
6 years ago by zentaro
Modified:
6 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support checking RsnFlags as well as WpaFlags so that security type is reported correctly for all networks. BUG=387869 Committed: https://crrev.com/1208e4a8c2747ecac847bfc0bf72a52d61a64551 Cr-Commit-Position: refs/heads/master@{#307090}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add blank line after comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M chrome/browser/extensions/api/networking_private/network_config_dbus_constants_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/network_config_dbus_constants_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_linux.cc View 1 3 chunks +27 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
zentaro
6 years ago (2014-12-04 17:54:13 UTC) #2
stevenjb
lgtm https://codereview.chromium.org/779053002/diff/1/chrome/browser/extensions/api/networking_private/networking_private_linux.cc File chrome/browser/extensions/api/networking_private/networking_private_linux.cc (right): https://codereview.chromium.org/779053002/diff/1/chrome/browser/extensions/api/networking_private/networking_private_linux.cc#newcode585 chrome/browser/extensions/api/networking_private/networking_private_linux.cc:585: // security modes. nit: blank space since the ...
6 years ago (2014-12-05 20:32:42 UTC) #3
zentaro
https://codereview.chromium.org/779053002/diff/1/chrome/browser/extensions/api/networking_private/networking_private_linux.cc File chrome/browser/extensions/api/networking_private/networking_private_linux.cc (right): https://codereview.chromium.org/779053002/diff/1/chrome/browser/extensions/api/networking_private/networking_private_linux.cc#newcode585 chrome/browser/extensions/api/networking_private/networking_private_linux.cc:585: // security modes. On 2014/12/05 20:32:42, stevenjb wrote: > ...
6 years ago (2014-12-05 21:16:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779053002/20001
6 years ago (2014-12-05 21:17:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-05 22:02:30 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-05 22:03:24 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1208e4a8c2747ecac847bfc0bf72a52d61a64551
Cr-Commit-Position: refs/heads/master@{#307090}

Powered by Google App Engine
This is Rietveld 408576698