Add lint_filters parameter to CheckChangeLintsClean function.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 72 matching lines @@
   file_filter = lambda x : x
   keyword = 'DO NOT ''SUBMIT'
   errors = _FindNewViolationsOfRule(lambda _, line : keyword not in line,
                                     input_api, file_filter)
   text = '\n'.join('Found %s in %s' % (keyword, loc) for loc in errors)
   if text:
     return [output_api.PresubmitError(text)]
   return []
 
 
-def CheckChangeLintsClean(input_api, output_api, source_file_filter=None):
+def CheckChangeLintsClean(input_api, output_api, source_file_filter=None,
+                          lint_filters=None):
   """Checks that all '.cc' and '.h' files pass cpplint.py."""
   _RE_IS_TEST = input_api.re.compile(r'.*tests?.(cc|h)$')
   result = []
 
   cpplint = input_api.cpplint
   # Access to a protected member _XX of a client class
   # pylint: disable=W0212
   cpplint._cpplint_state.ResetErrorCounts()
 
-  # Justifications for each filter:
-  #
-  # - build/include       : Too many; fix in the future.
-  # - build/include_order : Not happening; #ifdefed includes.
-  # - build/namespace     : I'm surprised by how often we violate this rule.
-  # - readability/casting : Mistakes a whole bunch of function pointer.
-  # - runtime/int         : Can be fixed long term; volume of errors too high
-  # - runtime/virtual     : Broken now, but can be fixed in the future?
-  # - whitespace/braces   : We have a lot of explicit scoping in chrome code.
-  # - readability/inheritance : Temporary, while the OVERRIDE and FINAL fixup
-  #                             is in progress.
-  cpplint._SetFilters('-build/include,-build/include_order,-build/namespace,'
-                      '-readability/casting,-runtime/int,-runtime/virtual,'
-                      '-whitespace/braces,-readability/inheritance')
+  if lint_filters != None:

[agable, 2014/12/09 21:34:48]

s/!=/is not/

+    cpplint._SetFilters(lint_filters)
+  else:
+    # Justifications for each filter:
+    #
+    # - build/include       : Too many; fix in the future.

[tfarina, 2014/12/08 01:05:39]

I want to enable these checks in app_list, as we cleaned them there, and to
avoid future regressions. But as we are filtering them out here, we are always
regressing this.

[Dirk Pranke, 2014/12/09 21:17:07]

It looks like ui/app_list/PRESUBMIT.py has its own copy of
CheckChangeLintsClean() and maybe only src/chrome calls this function;

perhaps we should just remove this function and move it to src/chrome if no one
else uses it and we think we might want different settings per component?

Apart from that, idiomatically, I'd probably expose the default list on lines
118-120 as a global constant, to allow callers to get the default set and modify
it, rather than forcing them to duplicate things.

Then I'd just change the start of this function to add on line 96 'lint_filters
= lint_filters or DEFAULT_LINT_FILTERS' and get rid of this branch.

+    # - build/include_order : Not happening; #ifdefed includes.
+    # - build/namespace     : I'm surprised by how often we violate this rule.
+    # - readability/casting : Mistakes a whole bunch of function pointer.
+    # - runtime/int         : Can be fixed long term; volume of errors too high
+    # - runtime/virtual     : Broken now, but can be fixed in the future?
+    # - whitespace/braces   : We have a lot of explicit scoping in chrome code.
+    # - readability/inheritance : Temporary, while the OVERRIDE and FINAL fixup
+    #                             is in progress.
+    cpplint._SetFilters('-build/include,-build/include_order,-build/namespace,'
+                        '-readability/casting,-runtime/int,-runtime/virtual,'
+                        '-whitespace/braces,-readability/inheritance')
 
   # We currently are more strict with normal code than unit tests; 4 and 5 are
   # the verbosity level that would normally be passed to cpplint.py through
   # --verbose=#. Hopefully, in the future, we can be more verbose.
   files = [f.AbsoluteLocalPath() for f in
            input_api.AffectedSourceFiles(source_file_filter)]
   for file_name in files:
     if _RE_IS_TEST.match(file_name):
       level = 5
     else:
@@ skipping 998 matching lines @@
   for f in affected_files:
     cmd = ['gn', 'format', '--dry-run', f.AbsoluteLocalPath()]
     rc = gn.main(cmd)
     if rc == 2:
       warnings.append(output_api.PresubmitPromptWarning(
           '%s requires formatting. Please run `gn format --in-place %s`.' % (
               f.AbsoluteLocalPath(), f.LocalPath())))
   # It's just a warning, so ignore other types of failures assuming they'll be
   # caught elsewhere.
   return warnings