Issue 77893003: Documentation update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 77893003: Documentation update (Closed)

Created:
7 years, 1 month ago by Søren Gjesse

Modified:
6 years, 11 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Documentation update Fix worngly indended sample code. Add a few samples. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30474

Patch Set 1 #

Total comments: 4

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -7 lines)			Patch
	M	sdk/lib/io/http.dart	View		2 chunks	+7 lines, -7 lines	0 comments	Download
	M	sdk/lib/io/process.dart	View		2 chunks	+16 lines, -0 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm https://codereview.chromium.org/77893003/diff/1/sdk/lib/io/process.dart File sdk/lib/io/process.dart (right): https://codereview.chromium.org/77893003/diff/1/sdk/lib/io/process.dart#newcode103 sdk/lib/io/process.dart:103: * p.stdout.pipe(stdout); Please use `stdout.addStream(p.stdout)` and likewise for ...

7 years, 1 month ago (2013-11-20 12:24:03 UTC) #2

Søren Gjesse

Committed patchset #1 manually as r30474 (presubmit successful).

7 years, 1 month ago (2013-11-20 15:40:24 UTC) #3

Søren Gjesse

6 years, 11 months ago (2014-01-02 09:19:30 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/77893003/diff/1/sdk/lib/io/process.dart
File sdk/lib/io/process.dart (right):

https://codereview.chromium.org/77893003/diff/1/sdk/lib/io/process.dart#newco...
sdk/lib/io/process.dart:103: *       p.stdout.pipe(stdout);
On 2013/11/20 12:24:04, Anders Johnsen wrote:
> Please use `stdout.addStream(p.stdout)` and likewise for stderr.

Done.

https://codereview.chromium.org/77893003/diff/1/sdk/lib/io/process.dart#newco...
sdk/lib/io/process.dart:153: *       stdout.write(result.stderr);
On 2013/11/20 12:24:04, Anders Johnsen wrote:
> stderr.write

Done.

Expand Messages | Collapse Messages