tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py - Issue 778923003: Added a comment about why testVTuneProfiler is disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py

Issue 778923003: Added a comment about why testVTuneProfiler is disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disabled test everywhere Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py b/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py

index de9baf32979b21319d6ca6c79039882d43ddce8b..225b542e55dcab2611df413ab8f803fe2ee35110 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py

@@ -96,7 +96,10 @@ class TestVTuneProfiler(unittest.TestCase):

class TestVTuneProfilerTabTestCase(tab_test_case.TabTestCase):

- @benchmark.Disabled('android') # crbug.com/437085

+ # This test is only meant to be run if VTune is installed locally. Please

+ # run it locally if you are modifying related code, but it's disabled on the

+ # bots because they don't have VTune. See crbug.com/437085

+ @benchmark.Disabled

def testVTuneProfiler(self):

mock_subprocess = MockSubprocess()

real_subprocess = vtune_profiler.subprocess

« no previous file with comments | « no previous file | no next file » | no next file with comments »